Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic enhancement #156

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Feb 15, 2024

Resolves #155

  • Hide everything by default so we don't see a flicker on load
  • Do nothing as the box underneath covers errors etc
  • Replaced only the checkPermitClaimable() error msg as we see it twice, once in the admin invalidate function so left that as that's grammatically correct

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly fine. Were you able to test it?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 15, 2024

Passing an empty array then an array with two objects simulating the claimTxs for QA purposes

image

image

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine:

  1. Error text is updated
  2. The "1/1 Reward" block is hidden if there is only 1 permit

@0x4007 0x4007 merged commit 63be8ab into ubiquity:development Feb 15, 2024
1 check passed
@ubiquibot ubiquibot bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic Enhancements
3 participants