-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Fetch Fastest RPC For Rewards dApp #151
Feature: Fetch Fastest RPC For Rewards dApp #151
Conversation
Regarding the issue, as far as I understand, metamask doesn't allow adding RPCs programmatically so as a part of the current issue we could:
Time estimate for the current issue is ~1 day. Overall I would save time and close current issue as "not planned" since current metamask RPCs work pretty fine both for mainnet and gnosis. @barebind
|
What I meant actually is that, you cannot add additional provider urls for already added specific networkId on metamask. So if you have Gnosis added to metamask with a slow rpc already, you cannot update or add additional faster providers to it.
I think it's the current state right now with rpc provider (not necessarily the fastest though) saved in I agree with a structural all-pages update for fastest rpc usage like you said.
I've used project's prettier settings(
Sure. |
For enhanced UX we can time the RPC request and if its slow e.g. longer than 1 second, we can have a message pop up that explains to the user to change the RPC endpoint to one that we recommend. From there the user can click to add it.
After the user attempts the first request, they will receive this notification to change the RPC and then they no longer have to worry about this problem.
I recently updated the prettier and linter settings across several repositories to match our |
I formatted the codebase and tried forcing GitHub Files view to update by toggling the branch to no avail. @barebind If you can handle the new merge conflicts then we can merge this in! |
Resolves #130
networkId
/chainId
is less confusing and also is compatible with specs.scripts/typescript/generate-permit2-url.ts
network
parameter in the url is not used so I removed it.networkId
fromClaimTx
is used instead.onboarding
has it's own switchNetwork functions etc. Some functions are shared across different UIs and some are not. Definitely confusing for newcomers.isNonceClaimed
always returns true for a new setup(new ubiquibot account) on Goerli. Something must be missing in the documentation. Don't know what and why.getOptimalRpc()
functionality. The current approach is definitely not the best one as it always calls whenever it needs rpc provider. There must be some context to store optimal provider and fetching optimal RPC must be on page load or something.