Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error arrays like AggregateError for proper display #64

Open
gentlementlegen opened this issue Jan 31, 2025 · 8 comments · May be fixed by #69
Open

Handle error arrays like AggregateError for proper display #64

gentlementlegen opened this issue Jan 31, 2025 · 8 comments · May be fixed by #69
Assignees
@whilefoo
Labels
Price: 50 USD Priority: 2 (Medium) Time: <1 Hour

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Jan 31, 2025 •
edited
Loading 

          maybe we should also handle `AggregateError` inside the SDK to have this functionality everywhere

Originally posted by @whilefoo in ubiquity-os-marketplace/command-start-stop#133 (comment)

Multiple aggregated errors do not get displayed properly by the SDK using postComment, because it is an array of errors instead of a single error with a single message. Error messages should get concatenated altogether.
@gentlementlegen gentlementlegen mentioned this issue Jan 31, 2025
Merged
Open
@whilefoo
Copy link
Member

whilefoo commented Feb 6, 2025

Errors should be split by two empty lines \n\n and should not be prefixed with Error:

Example:

Warning

No price label is set to calculate the duration

This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 5 (Emergency)

@ubiquity-os-beta ubiquity-os-beta
Copy link

Note

The following contributors may be suitable for this task:

gentlementlegen

76% Match ubiquity-os-marketplace/command-start-stop#60

@ubiquity-os-beta ubiquity-os-beta
Copy link

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 3 days and 12 hours if there is no activity.
  • Assignees will be disqualified after 7 days of inactivity.

@ubiquity-os-beta ubiquity-os-beta
Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @whilefoo.

@0x4007
Copy link
Member

0x4007 commented Feb 11, 2025

@whilefoo I thought you fixed this was there another similar problem and pull? I remember reviewing it.

@whilefoo
Copy link
Member

Yes, I was waiting for #63 to get merged

@0x4007
Copy link
Member

0x4007 commented Feb 11, 2025

Looks like its merged.

@ubiquity-os-beta ubiquity-os-beta
Copy link

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 3 days and 12 hours if there is no activity.
  • Assignees will be disqualified after 7 days of inactivity.

@whilefoo whilefoo linked a pull request Feb 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whilefoo whilefoo

Labels
Price: 50 USD Priority: 2 (Medium) Time: <1 Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support AggregateError ubiquity-whilefoo/plugin-sdk
3 participants
@0x4007 @gentlementlegen @whilefoo