Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

feat!: configuration cleaned up from the old version #17

Merged
merged 7 commits into from
May 7, 2024
Merged

feat!: configuration cleaned up from the old version #17

merged 7 commits into from
May 7, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #16

@gentlementlegen
Copy link
Member Author

Aims to resolve the conversation we had with @whilefoo here, so that plugins define their own needed configuration while the kernel only needs the plugin list (for now at least), so all the old configuration elements have been removed.

@gentlementlegen gentlementlegen mentioned this pull request May 6, 2024
Merged
gitcoindev
gitcoindev approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gitcoindev gitcoindev merged commit b85c169 into ubiquity-os:development May 7, 2024
2 checks passed
@ubiquibot ubiquibot bot mentioned this pull request May 7, 2024
Closed
@gentlementlegen gentlementlegen deleted the fix/cleanup-configuration branch May 7, 2024 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gitcoindev gitcoindev gitcoindev approved these changes

@molecula451 molecula451 Awaiting requested review from molecula451

@whilefoo whilefoo Awaiting requested review from whilefoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup unused configuration properties
2 participants
@gentlementlegen @gitcoindev