Agent #1
Agent #1
Conversation
|
|
||
| - Your plugin config should look similar to this: | ||
| - Generate a Github clasic Personal Access Token PAT with access to repositories. |
There was a problem hiding this comment.
| - Generate a Github clasic Personal Access Token PAT with access to repositories. | |
| - Generate a GitHub classic Personal Access Token PAT with access to repositories. |
There was a problem hiding this comment.
CSpell should have caught this. Are your pre commit hooks running?
There was a problem hiding this comment.
Yes CSpell ran: https://github.com/ubiquity-os-marketplace/personal-agent/actions/runs/13137497851/job/36656295119#step:4:66
It only checks typescript files.
There was a problem hiding this comment.
Perhaps we should add markdown files as well!
There was a problem hiding this comment.
It should've spell checked markdown files because it's not listed in ignorePaths, if we use files instead of ignorePaths then you need to explicitly set all paths
| @@ -0,0 +1 @@ | |||
| GITHUB_PAT_ENCRYPTED: S6K1T2liquv_G9yS2GxGf20NSHMAVDmX7DDx9-hnjG9518z2TKiWuEZrJobREMFzbBPiCvS1R3peatoiyR6phdjVWmeFM4FNAFp6neO5iUu2kVFVU-r2XvXuFAj-rL8RKEF3XC6yInobjcai | |||
There was a problem hiding this comment.
Hey actually this should just be in the repository secrets. No need for a new config file or encryption @whilefoo
There was a problem hiding this comment.
Technically this would be possible if user's personal-agent had the Ubiquity app installed, but the problem would be that the SDK creates an Octokit instance from the authToken received from the kernel/bridge, so if we didn't any token it would fail.
We could modify the SDK to look for env variable if authToken is empty or supply it when creating the plugin like
createActionsPlugin(handler, { customToken: env.GITHUB_PAT })
| @@ -13,6 +13,6 @@ export default createActionsPlugin<PluginSettings, Env, null, SupportedEvents>( | |||
| envSchema: envSchema, | |||
| ...(process.env.KERNEL_PUBLIC_KEY && { kernelPublicKey: process.env.KERNEL_PUBLIC_KEY }), | |||
| postCommentOnError: true, | |||
| bypassSignatureVerification: process.env.NODE_ENV === "local", | |||
| bypassSignatureVerification: true, | |||
There was a problem hiding this comment.
The bridge doesn't have functionality to generate a signature, I'd have to copy a lot of code from the kernel to the bridge, but then it'd make more sense to just have this as part of the kernel like I suggested before.
There was a problem hiding this comment.
Let's go with your suggestion. I've never worked with the kernel code so I have limited insight.
| env: | ||
| PLUGIN_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| KERNEL_PUBLIC_KEY: ${{ secrets.KERNEL_PUBLIC_KEY }} | ||
| LOG_LEVEL: ${{ secrets.LOG_LEVEL || 'info' }} |
There was a problem hiding this comment.
I think there is a way to dynamically check the owner of the repository so that we can automatically catch the correct @xxx name
There was a problem hiding this comment.
/ask in a github action workflow .yml file, how can i get my github user name if I own the repository?
There was a problem hiding this comment.
The bridge only triggers the personal agent if it matches the owner but I can add the check in the personal agent if you think it's worth
There was a problem hiding this comment.
/ask in a github action workflow .yml file, how can i get my github user name if I own the repository?
|
Caution No answer from OpenAI |
Thinking is not posted in the review thread. Also should have the tip syntax: Tip Syntax Caution No answer from OpenAI @shiv810 can you address these |
It doesn't post to review threads at all anymore |
Resolves ubiquity-os/plugins-wishlist#3