Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename bromite -> cromite scripts #635

Merged
merged 8 commits into from
Dec 27, 2023
Merged

Rename bromite -> cromite scripts #635

merged 8 commits into from
Dec 27, 2023

Conversation

uazo
Copy link
Owner

@uazo uazo commented Dec 23, 2023 •
edited
Loading

Description

a year later, the time has come.

All submissions

  • there are no other open Pull Requests for the same update/change
  • Cromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

fixes #280

@uazo
Copy link
Owner Author

uazo commented Dec 23, 2023

test Builds and pushes tagged image to DockerHub
https://github.com/uazo/cromite/actions/runs/7308402236

@uazo uazo marked this pull request as ready for review December 27, 2023 10:43
@uazo uazo merged commit 828c891 into master Dec 27, 2023
1 check failed
@uazo uazo deleted the use-cromite-name branch December 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra] Remove /tools/images/bromite-build/build_args.gni
1 participant
@uazo