-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tfguf:0.0.1 #1688
tfguf:0.0.1 #1688
Conversation
Corrected tfg.typ to use @Preview name space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font files should not be shipped with packages. Instead you should add instructions to download and import them in your README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Font files have been removed as requested. Instructions are now in the README.md file. Thanks @elegaanz.
# TFG UNIR Física | ||
This template is used to make bachelor thesis works for the degree in Physics at Universidad Internacional de La Rioja. | ||
|
||
![](https://p.ipic.vip/vbt7pt.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an actual alternative text for this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
[template] | ||
path = "./" | ||
entrypoint = "tfg.typ" | ||
thumbnail = "uflogo.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thumbnail should generally show a page of a document generated with your template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
categories = ["thesis"] | ||
|
||
[template] | ||
path = "./" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template files should be in their own subdirectory: this directory will be copied as is to the user's project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Sorry for any inconveniences.
Thanks very much @elegaanz.
Added instructions to download and use the Calibri font as requested by the Reviewer. Image also has now an alt text.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Added template directory and new reference to thumbnail image.
Sorry for my successive PRs… I'm mastering Typst packaging… But I humbly think I have a working version now. |
Yes, everything looks good, thank you! |
I am submitting
Description: This package allows physics students in the degree in Physics at Unir University to write their bachelor thesis in Typst.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE