Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfguf:0.0.1 #1688

Merged
merged 30 commits into from
Feb 11, 2025
Merged

tfguf:0.0.1 #1688

merged 30 commits into from
Feb 11, 2025

Conversation

pammacdotnet
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description: This package allows physics students in the degree in Physics at Unir University to write their bachelor thesis in Typst.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot changed the title Initial version for the template for Bachelor Thesis in the degree in Physics (UNIR) tfguf:0.0.1 Feb 8, 2025
@typst-package-check typst-package-check bot added the new A new package submission. label Feb 8, 2025
@pammacdotnet
Copy link
Contributor Author

Corrected tfg.typ to use @Preview name space.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font files should not be shipped with packages. Instead you should add instructions to download and import them in your README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font files have been removed as requested. Instructions are now in the README.md file. Thanks @elegaanz.

# TFG UNIR Física
This template is used to make bachelor thesis works for the degree in Physics at Universidad Internacional de La Rioja.

![](https://p.ipic.vip/vbt7pt.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an actual alternative text for this image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

[template]
path = "./"
entrypoint = "tfg.typ"
thumbnail = "uflogo.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thumbnail should generally show a page of a document generated with your template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

categories = ["thesis"]

[template]
path = "./"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template files should be in their own subdirectory: this directory will be copied as is to the user's project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Sorry for any inconveniences.
Thanks very much @elegaanz.

Added instructions to download and use the Calibri font as requested by the Reviewer. Image also has now an alt text.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Deleted as requested in the review process.
Added template directory and new reference to thumbnail image.
@pammacdotnet
Copy link
Contributor Author

Sorry for my successive PRs… I'm mastering Typst packaging… But I humbly think I have a working version now.

@elegaanz
Copy link
Member

Yes, everything looks good, thank you!

@elegaanz elegaanz merged commit a1cf59a into typst:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants