Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illc-mol-thesis:0.1.0 #1574

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

illc-mol-thesis:0.1.0 #1574

wants to merge 4 commits into from

Conversation

foxyseta
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

This is a Typst port of the official "Master of Logic Titlepage" used by Master of Logic students at the ILLC in their thesis. It is useful for MoL students typesetting their MSc thesis in Typst.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE

@elegaanz elegaanz added the new A new package submission. label Jan 15, 2025
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission!

packages/preview/illc-mol-thesis/0.1.0/LICENSE Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you designed this logo and it is under the same license as the rest of the package, you should include a Copyright / license notice in your README or LICENSE file. Also please make sure that it is fine to redistribute the institution logo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikr. When I was doing this, I was like, "this cannot be possibly right, but I cannot find a license for this anywhere" 🤣 I will look into this with the administration of the institution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently waiting for the logo to actually be released with a license, so it will take some time, but I am optimistic on the matter.

packages/preview/illc-mol-thesis/0.1.0/src/main.typ Outdated Show resolved Hide resolved
Comment on lines +1 to +2
[package]
name = "illc-mol-thesis"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless this package is also officially endorsed by the institute, I would like you to rename it to make its name more distinctive. If it is an official template, can you ask a member of the staff to send an email to [email protected] stating so, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the staff would be fine with making this official, as none of them are Typst users (that I know of), so I would still be the only package maintainer even after graduation.

Still, I will look into this and maybe have this endorsed via email. In case this fails, would logical-master-thesis be distinctive enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we'll see how it goes.

And the potential new name would be fine in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The board seems willing to endorse this by eventually emailing [email protected]. However, I was informed that the $\LaTeX$ titlepage is currently being extended into a full-fledged $\LaTeX$ template. Because of this, I shall also need to catch up to this work and extend this package into a full-fledged Typst template.

Of course, I can only finish this port after the original template's design process is complete, so this will take a while. Shall I mark this PR as a draft for now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you. If you prefer we can also merge this first version as soon as I get the email, and let you publish an update once you've ported the full template to Typst.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would also work. It might take a while for the logo to be properly licensed and the email to be sent, but when this happens, I'd be very happy to add the missing logo licence and see this first version 0.1.0 released. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants