modern-cornell-notebooks:0.2.0 #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Cornell style template based on the xyznote, with a restructured code format.
|
I just "sync" the fork and found this PR disappear... |
elegaanz
reviewed
Jan 15, 2025
| @@ -0,0 +1,138 @@ | |||
| #import "../lib/lib.typ": * | |||
There was a problem hiding this comment.
You should use the package import here:
Suggested change
| #import "../lib/lib.typ": * | |
| #import "@preview/modern-cornell-notebooks:0.2.0": * |
| version = "0.2.0" | ||
| entrypoint = "template/cornell.typ" | ||
| license = "MIT" | ||
| description = "A Typst template for creating notebooks with cornell style." |
There was a problem hiding this comment.
"A typst template" is redundant:
Suggested change
| description = "A Typst template for creating notebooks with cornell style." | |
| description = "Notebooks with Cornell style." |
There was a problem hiding this comment.
Maybe this would be more correctly phrased as "Notebooks in the Cornell style", but I'm no English expert, so if it sounds bad to you feel free to ignore me.
| [package] | ||
| name = "modern-cornell-notebooks" | ||
| version = "0.2.0" | ||
| entrypoint = "template/cornell.typ" |
There was a problem hiding this comment.
This should point to lib/lib.typ instead (or at least to a file that is not part of your template).
Suggested change
| entrypoint = "template/cornell.typ" | |
| entrypoint = "lib/lib.typ" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting
Description:A Cornell style template based on the xyznote, with a restructured code format.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE