Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlseinp-report:0.1.0 #1480

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

tlseinp-report:0.1.0 #1480

wants to merge 4 commits into from

Conversation

Killian-fal
Copy link

I am submitting

  • a new package
  • an update for a package

Description: The goal of this template is to let students at Toulouse INP schools write reports using typst. Currently, everyone still uses Latex, so I've translated the template into typst while adding a few features to let people who don't like Latex (me, for example) use your solution :)

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot added the new A new package submission. label Dec 27, 2024
description = "Template for Toulouse INP students."

[template]
path = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templates should go in their own subdirectory. The content of this directory will be copied when creating a project from your template, so it should probably contain a new file that imports @preview/tlseinp-report:0.1.0 and set ups the document with a minimal working example.

}

// show a list of livrables
#let deliverables(headingName: "Deliverables", dict) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more consistent with other parts of your package and with the rest of the Typsy ecosystem it would be nice to rename headingName to heading-name.

}

// show the list of figures in the document
#let figures(headingName: "Table of figures", kind: image) = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@elegaanz
Copy link
Member

elegaanz commented Jan 7, 2025

Also, do you have the rights to distribute the logos of the various schools?

@elegaanz
Copy link
Member

Hello, do you think you will have time to make the necessary changes soon? If not I'll close this PR to keep the review backlog clear (you can re-open another PR when you're ready).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants