wenyuan-campaign:0.1.0

[yanwenywan]

I am submitting

• a new package
• an update for a package

Description: This package recreates the LaTeX DnD 5e-style campaign document for Typst, for all game masters who want to write (or publish!) their campaign documents in a format like published campaigns, and for reasons prefer to use typst or do not want to go through the trouble of manually installing a LaTeX package, dealing with long compile times, etc.

I have read and followed the submission guidelines and, in particular, I

• selected a name that isn't the most obvious or canonical name for what the package does
• added a typst.toml file with all required keys
• added a README.md with documentation for my package
• have chosen a license and added a LICENSE file or linked one in my README.md
• tested my package locally on my system and it worked
• excluded PDFs or README images, if any, but not the LICENSE

• ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

[yanwenywan]

Not quite sure why the package check is bringing up "This PR does too many things", please advise if there's any issues, thanks

[elegaanz]

Thank you for the nice template!

Sorry about the CI bug, it is a known. I did a manual review instead.

For info, it is more common in the Typst ecosystem to use kebab-case names for functions and their arguments, so you may want to change that (but you can also keep camelCase if you prefer).

[yanwenywan]

Thanks for you feedback. It's no problem to change the names, I don't think I ever realised Typst allows kebab-case until recently lol

[yanwenywan]

Okay, it's still unhappy about a camelCase name, but that's not really part of the intended public interface 😅 everything that's meant to be used by a user should be now kebab case

Also, sorry about the few last straggler bugs and features that need to be added in before merge

[elegaanz]

Thank you for renaming the package and fixing the issues.

FYI, you can silence warnings about kebab-case by prefixing names with a _. The item would still be accessible, be it is clearer that it is supposed to be private. If you want it to not be public at all, the correct solution is to have an entrypoint file that only imports items that should be public from other files. I'm not suggesting you to do that here, just giving you the information so that you have it next time.

Also, sorry about the few last straggler bugs and features that need to be added in before merge

Please tell me when you're ready for another review then :)

[yanwenywan]

Thanks for your advice. I've gone through the package once more and ported one of my own small campaigns to typst, I can't see any more problems so it's probably good to release to the wild

Ready for review whenever you are.

[elegaanz]

Great, everything looks good to me, thanks!