Fix unnecessary disambiguation around ibids #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129.
Disambiguation currently compares the normal render of a citation. This means that if two different citations both render to "ibid", they are disambiguated without actually being ambiguous. This PR solves that by creating a second render that disables ibids and using that for comparison.
Example:
bibliography.yaml
Faulty render without this PR
![Screenshot 2024-11-20 154755](https://private-user-images.githubusercontent.com/63172826/388143249-f8f93660-c972-421c-a322-9a9ff6af67f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTUxMzUsIm5iZiI6MTczOTYxNDgzNSwicGF0aCI6Ii82MzE3MjgyNi8zODgxNDMyNDktZjhmOTM2NjAtYzk3Mi00MjFjLWEzMjItOWE5ZmY2YWY2N2Y0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMjAzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmOGY1Y2JiZGVkNDg1NTlkZGQ4NjIxODQ3MzZkYzdkYWRlYTkyNDE1NGFmOTliZWFlZDQzNDAyMTM5NDFiMDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9tmTyG0ZV7hzdz5wjrSy_8_3VQ6OOVOtAG7ngjM1_zI)
Correct render with this PR
![image](https://private-user-images.githubusercontent.com/63172826/388144761-a6a8c56d-1a15-4757-ab14-3de3703366dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTUxMzUsIm5iZiI6MTczOTYxNDgzNSwicGF0aCI6Ii82MzE3MjgyNi8zODgxNDQ3NjEtYTZhOGM1NmQtMWExNS00NzU3LWFiMTQtM2RlMzcwMzM2NmRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDEwMjAzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkYWIwNTEwNGQ4N2U3YjE4OGQxM2UxODc3Mjg5NzFkMDk3MjkyOGI0ODNkMzZlYjJlZjFhNWI0YTU4ZjEwNjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.j9Obppaqv7K7TnQUyAM87OmJvsfqF6cagGBUc1Z4kjM)