feat: Introduce InlayHints #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
chietala/inlay-hints
branch
from
821fe6a to
943d596
Compare
dfreeman
reviewed
Mar 15, 2023
There was a problem hiding this comment.
I feel silly having to ask, but I pulled this branch to try it out and I can't seem to get any inlays in .gts files. I've cranked my inlay settings up to 11 in my user settings, and I see everything appearing in .ts files from the built-in TS tooling, but nothing in any of the GTS files.
I saw the gif you posted of this working in a GTS file in Discord—is there an additional setting I'm missing?
Comment on lines
+394
to
+404
| this.getTransformedOffsetsFromPositions( | ||
| uri, | ||
| { | ||
| line: range.start.line, | ||
| character: range.start.character, | ||
| }, | ||
| { | ||
| line: range.end.line, | ||
| character: range.end.character, | ||
| } | ||
| ); |
There was a problem hiding this comment.
Can this just be getTransformedOffsetsFromPositions(uri, range.start, range.end)?
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Debug Current Test File", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces InlayHints to the Glint language server.
As part of this I noticed that for the extension we were not massaging TypeScript and JavaScript preferences and formatting configs correctly. I have largely borrowed how vscode does this re-mapping for TypeScript.