Fix unsafe mutable static warnings #8229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
rust-console-warning-fix
branch
from
ab9e75b to
d36b3ad
Compare
Keep a Console always in existence, but make it so the sender can be set/unset. We can do this by using Once to ensure that our panic hook and logger are set once, and then having Console be pre-initialized with the sender set to None. This ensures we do not need any static mutables, thus Console can be inited and deinited safely. Co-authored-by: hrb <[email protected]> Co-authored-by: ivk <[email protected]>
paw-hub
force-pushed
the
rust-console-warning-fix
branch
from
d36b3ad to
2184238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a Console always in existence, but make it so the sender can be set/unset. We can do this by using Once to ensure that our panic hook and logger are set once, and then having Console be pre-initialized with the sender set to None.
This ensures we do not need any static mutables, thus Console can be inited and deinited safely.