Add support for Database.interrupt() #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen0wu
reviewed
Dec 17, 2024
| /** | ||
| * Interrupts the database connection. | ||
| */ | ||
| interrupt() { |
There was a problem hiding this comment.
is this function actually useful in the sync world (since there's no way to call it really)? unless... users can define UDF to get back into JS? 🤔
There was a problem hiding this comment.
@zen0wu If your application uses Web Workers, you could call this, no? Not saying it's very common way to write apps, but in theory useful?
haaawk
reviewed
Dec 18, 2024
| @@ -19,6 +19,7 @@ pub fn throw_libsql_error<'a, C: Context<'a>, T>(cx: &mut C, err: libsql::Error) | |||
| cx.throw(err)? | |||
| } | |||
| _ => { | |||
| todo!("err = {:?}", err); | |||
There was a problem hiding this comment.
Is this left here on purpose @penberg ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #123