Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige verificação do goodtables #181

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Corrige verificação do goodtables #181

merged 5 commits into from
Jun 29, 2020

Conversation

endersonmaia
Copy link
Collaborator

/fixes #180

@endersonmaia endersonmaia self-assigned this Jun 28, 2020
@endersonmaia endersonmaia marked this pull request as draft June 28, 2020 13:03
@endersonmaia endersonmaia changed the title Corride verificação do goodtables Corrige verificação do goodtables Jun 28, 2020
@endersonmaia endersonmaia marked this pull request as ready for review June 28, 2020 14:21
@endersonmaia
Copy link
Collaborator Author

endersonmaia commented Jun 28, 2020

@augusto-herrmann se puder dar uma revisada aí nas descrições dos campos, agradeço

o validate.sh tá OK ✅

Copy link
Contributor

@augusto-herrmann augusto-herrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado! 👍

.github/workflows/goodtables.yaml Show resolved Hide resolved
datapackage.json Show resolved Hide resolved
@endersonmaia
Copy link
Collaborator Author

Verificando aqui as descrições comparando com a documentação da API, percebi que :

  • na documentação da API, a ordem dos campos é diferente no schema;
  • somente para covid19 há ênfase em suspeita ou confirmação

eu vou mandar um ajuste no datapackage.json normalizando mais ainda as descrições dos campos

e devo também mandar um ajuste na ordem dos campos na documentação da API para refletir a ordem dos campos no schema/datapackage/csv.

@endersonmaia endersonmaia merged commit c851dff into master Jun 29, 2020
@endersonmaia endersonmaia deleted the goodtables-fix branch June 30, 2020 22:55
momenezes pushed a commit to momenezes/covid19-br that referenced this pull request Jul 1, 2020
* corrige ordem dos campos no `boletim.csv`
* adiciona campos ao `datapackage.json` da tabela `obitos_cartorio.csv`
* habilita verificação goodtables para `push`, e `pull_request`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistências na base de dados
2 participants