Adding Asyncio Support #35
Open
+283
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Backend] Adding Asyncio Support
|
Hey guys, just wanted to comment that not allowing reuse of clients when creating namespaces has a great impact on performance (in cases when you have a large number of namespaces), particularly related to having to make the TLS/SSL handshake everytime you make a request to a namespace. I would highly recommend allowing the end user of the sdk to pass down Or possibly doing it in a way described here: #22 (comment) |
|
@philipk19238 are you running this in prod? |
- Changed API URL construction to include versioning (/v1/) for better clarity and organization. - Modified error handling to raise exceptions for additional HTTP status codes (408 and 429) alongside server errors (500+). - Improved condition for checking 'Server-Timing' header to ensure it is not empty before processing.
|
This would be a welcome addition |
Sorry just saw this - yes have been using. We have a more recent build I can PR if this is an approach the team is aligned on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_api_request_asyncmethod toBackendaquerythat integrates the async request executortest_async_query