migrated code with 0 completed tests #23
Conversation
|
I changed the target branch to Please synchronize your branch and resolve the conflicts that this migration brought. Here are some links for help on how to build a typescript with rollup: |
package.json
Outdated
| "directories": { | ||
| "test": "test" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
Why there are so many dependencies when the library actually uses nothing from this? 🤔
The library should be as clean as possible, so most of the dependencies should be dev dependencies.
| * @param word - The word to insert. | ||
| * @param data - Optional data to map to the word. | ||
| */ | ||
| insert(word: string, data?: any): boolean { |
There was a problem hiding this comment.
This class could be defined with a generic type (i.e. Trie<T>) so data in a trie can have a type.
The type any can be avoided this way.
https://www.typescriptlang.org/docs/handbook/2/generics.html
src/trie/TrieNode.ts
Outdated
| * If the node is the end of a word, it has the flag `isEndOfWord` set to true and `word` is set to the indexed word. | ||
| * If the node is the end of a word, it can contain some additional data. | ||
| */ | ||
| export default class TrieNode { |
There was a problem hiding this comment.
If you make Trie a class with generic type you need to also change it here to TrieNode<T> because here data is actually stored.
SlimTimDotPng
force-pushed
the
code_migration
branch
from
28c56b5 to
6481472
Compare
|
It should be fixed now. When i run it using "npx jest" the tests pass. |
|
I accidentally closed the RP so i'll reopen it. |
I managed to migrated the code base as you asked but i think there is a chance that the karma framework does not work with typescript. I had some issues with building the program but i managed to fix it today. Let me know if this is sufficient.