plugin: remove cert-manager request by name

tsuru · Sep 16, 2024 · c5eb5ea · c5eb5ea
1 parent 9a914af
commit c5eb5ea
Show file tree

Hide file tree

Showing 6 changed files with 120 additions and 11 deletions.
diff --git a/cmd/plugin/rpaasv2/cmd/certificates.go b/cmd/plugin/rpaasv2/cmd/certificates.go
@@ -192,7 +192,13 @@ func runDeleteCertificate(c *cli.Context) error {
 	}
 
 	if c.Bool("cert-manager") {
-		if err = client.DeleteCertManager(c.Context, c.String("instance"), c.String("issuer")); err != nil {
+		if c.String("name") != "" {
+			err = client.DeleteCertManagerByName(c.Context, c.String("instance"), c.String("name"))
+		} else {
+			err = client.DeleteCertManagerByIssuer(c.Context, c.String("instance"), c.String("issuer"))
+		}
+
+		if err != nil {
 			return err
 		}
 

diff --git a/cmd/plugin/rpaasv2/cmd/certificates_test.go b/cmd/plugin/rpaasv2/cmd/certificates_test.go
@@ -219,17 +219,30 @@ func TestDeleteCertificate(t *testing.T) {
 			expected: "certificate \"my-instance.example.com\" successfully deleted on my-instance\n",
 		},
 		{
-			name: "removing a certificate request for Cert Manager",
+			name: "removing a certificate request for Cert Manager by issuer",
 			args: []string{"./rpaasv2", "certificates", "delete", "-i", "my-instance", "--cert-manager", "--issuer", "some-issuer"},
 			client: &fake.FakeClient{
-				FakeDeleteCertManager: func(instance, issuer string) error {
+				FakeDeleteCertManagerByIssuer: func(instance, issuer string) error {
 					assert.Equal(t, "my-instance", instance)
 					assert.Equal(t, "some-issuer", issuer)
 					return nil
 				},
 			},
 			expected: "cert manager integration was disabled\n",
 		},
+
+		{
+			name: "removing a certificate request for Cert Manager by issuer",
+			args: []string{"./rpaasv2", "certificates", "delete", "-i", "my-instance", "--cert-manager", "--name", "some-name"},
+			client: &fake.FakeClient{
+				FakeDeleteCertManagerByName: func(instance, name string) error {
+					assert.Equal(t, "my-instance", instance)
+					assert.Equal(t, "some-name", name)
+					return nil
+				},
+			},
+			expected: "cert manager integration was disabled\n",
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/pkg/rpaas/client/certificate.go b/pkg/rpaas/client/certificate.go
@@ -193,7 +193,34 @@ func (c *client) UpdateCertManager(ctx context.Context, args UpdateCertManagerAr
 	return nil
 }
 
-func (c *client) DeleteCertManager(ctx context.Context, instance, issuer string) error {
+func (c *client) DeleteCertManagerByName(ctx context.Context, instance, name string) error {
+	if instance == "" {
+		return ErrMissingInstance
+	}
+
+	data := url.Values{}
+	if name != "" {
+		data.Set("name", name)
+	}
+
+	req, err := c.newRequestWithQueryString("DELETE", fmt.Sprintf("/resources/%s/cert-manager", instance), nil, data)
+	if err != nil {
+		return err
+	}
+
+	response, err := c.do(ctx, req)
+	if err != nil {
+		return err
+	}
+
+	if response.StatusCode != http.StatusOK {
+		return newErrUnexpectedStatusCodeFromResponse(response)
+	}
+
+	return nil
+}
+
+func (c *client) DeleteCertManagerByIssuer(ctx context.Context, instance, issuer string) error {
 	if instance == "" {
 		return ErrMissingInstance
 	}

diff --git a/pkg/rpaas/client/certificate_test.go b/pkg/rpaas/client/certificate_test.go
@@ -303,7 +303,7 @@ func TestClientThroughTsuru_UpdateCertManager(t *testing.T) {
 	}
 }
 
-func TestClientThroughTsuru_DeleteCertManager(t *testing.T) {
+func TestClientThroughTsuru_DeleteCertManagerByIssuer(t *testing.T) {
 	tests := map[string]struct {
 		instance      string
 		issuer        string
@@ -344,7 +344,59 @@ func TestClientThroughTsuru_DeleteCertManager(t *testing.T) {
 			client, server := newClientThroughTsuru(t, tt.handler)
 			defer server.Close()
 
-			err := client.DeleteCertManager(context.TODO(), tt.instance, tt.issuer)
+			err := client.DeleteCertManagerByIssuer(context.TODO(), tt.instance, tt.issuer)
+			if tt.expectedError == "" {
+				require.NoError(t, err)
+				return
+			}
+
+			assert.EqualError(t, err, tt.expectedError)
+		})
+	}
+}
+
+func TestClientThroughTsuru_DeleteCertManagerByName(t *testing.T) {
+	tests := map[string]struct {
+		instance      string
+		name          string
+		expectedError string
+		handler       http.HandlerFunc
+	}{
+		"when removing a Cert Manager request with no issuer provided": {
+			instance: "my-instance",
+			handler: func(w http.ResponseWriter, r *http.Request) {
+				assert.Equal(t, fmt.Sprintf("/1.20/services/%s/resources/%s/cert-manager", FakeTsuruService, "my-instance"), r.URL.RequestURI())
+				assert.Equal(t, "DELETE", r.Method)
+				w.WriteHeader(http.StatusOK)
+			},
+		},
+
+		"when removing a Cert Manager request from a specific issuer": {
+			instance: "my-instance",
+			name:     "my-name",
+			handler: func(w http.ResponseWriter, r *http.Request) {
+				assert.Equal(t, fmt.Sprintf("/1.20/services/%s/resources/%s/cert-manager?name=my-name", FakeTsuruService, "my-instance"), r.URL.RequestURI())
+				assert.Equal(t, "DELETE", r.Method)
+				w.WriteHeader(http.StatusOK)
+			},
+		},
+
+		"when server returns an error": {
+			instance: "my-instance",
+			handler: func(w http.ResponseWriter, r *http.Request) {
+				w.WriteHeader(http.StatusNotFound)
+				fmt.Fprintf(w, `{"Msg": "some error"}`)
+			},
+			expectedError: `rpaasv2: unexpected status code: 404 Not Found, detail: {"Msg": "some error"}`,
+		},
+	}
+
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+			client, server := newClientThroughTsuru(t, tt.handler)
+			defer server.Close()
+
+			err := client.DeleteCertManagerByName(context.TODO(), tt.instance, tt.name)
 			if tt.expectedError == "" {
 				require.NoError(t, err)
 				return

diff --git a/pkg/rpaas/client/client.go b/pkg/rpaas/client/client.go
@@ -180,7 +180,8 @@ type Client interface {
 
 	ListCertManagerRequests(ctx context.Context, instance string) ([]types.CertManager, error)
 	UpdateCertManager(ctx context.Context, args UpdateCertManagerArgs) error
-	DeleteCertManager(ctx context.Context, instance, issuer string) error
+	DeleteCertManagerByName(ctx context.Context, instance, name string) error
+	DeleteCertManagerByIssuer(ctx context.Context, instance, issuer string) error
 
 	GetMetadata(ctx context.Context, instance string) (*types.Metadata, error)
 	SetMetadata(ctx context.Context, instance string, metadata *types.Metadata) error

diff --git a/pkg/rpaas/client/fake/client.go b/pkg/rpaas/client/fake/client.go
@@ -38,7 +38,6 @@ type FakeClient struct {
 	FakeSetService              func(service string) error
 	FakeListCertManagerRequests func(instance string) ([]types.CertManager, error)
 	FakeUpdateCertManager       func(args client.UpdateCertManagerArgs) error
-	FakeDeleteCertManager       func(instance, issuer string) error
 	FakeLog                     func(args client.LogArgs) error
 	FakeAddExtraFiles           func(args client.ExtraFilesArgs) error
 	FakeUpdateExtraFiles        func(args client.ExtraFilesArgs) error
@@ -48,6 +47,9 @@ type FakeClient struct {
 	FakeGetMetadata             func(instance string) (*types.Metadata, error)
 	FakeSetMetadata             func(instance string, metadata *types.Metadata) error
 	FakeUnsetMetadata           func(instance string, metadata *types.Metadata) error
+
+	FakeDeleteCertManagerByName   func(instance, name string) error
+	FakeDeleteCertManagerByIssuer func(instance, issuer string) error
 }
 
 func (f *FakeClient) Info(ctx context.Context, args client.InfoArgs) (*types.InstanceInfo, error) {
@@ -221,9 +223,17 @@ func (f *FakeClient) UpdateCertManager(ctx context.Context, args client.UpdateCe
 	return nil
 }
 
-func (f *FakeClient) DeleteCertManager(ctx context.Context, instance, issuer string) error {
-	if f.FakeDeleteCertManager != nil {
-		return f.FakeDeleteCertManager(instance, issuer)
+func (f *FakeClient) DeleteCertManagerByName(ctx context.Context, instance, name string) error {
+	if f.FakeDeleteCertManagerByName != nil {
+		return f.FakeDeleteCertManagerByName(instance, name)
+	}
+
+	return nil
+}
+
+func (f *FakeClient) DeleteCertManagerByIssuer(ctx context.Context, instance, issuer string) error {
+	if f.FakeDeleteCertManagerByName != nil {
+		return f.FakeDeleteCertManagerByName(instance, issuer)
 	}
 
 	return nil