Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

replace .then test example with current async await test #1254

Merged
merged 2 commits into from
Jun 3, 2022
Merged

replace .then test example with current async await test #1254

merged 2 commits into from
Jun 3, 2022

Conversation

lsqproduction
Copy link
Contributor

This addresses #686.
Removed the .then() example.
Updated the Async await example with the current code in Metacoin test.

eggplantzzz
eggplantzzz approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@eggplantzzz eggplantzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@lsqproduction lsqproduction requested a review from cds-amal June 2, 2022 19:22
eggplantzzz
eggplantzzz approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@eggplantzzz eggplantzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@lsqproduction lsqproduction merged commit 287a110 into main Jun 3, 2022
@lsqproduction lsqproduction deleted the testExampleUpdate branch June 3, 2022 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eggplantzzz eggplantzzz eggplantzzz approved these changes

@kevinbluer kevinbluer Awaiting requested review from kevinbluer

@emilyJLin95 emilyJLin95 Awaiting requested review from emilyJLin95

@leeftk leeftk Awaiting requested review from leeftk

@cds-amal cds-amal Awaiting requested review from cds-amal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsqproduction @eggplantzzz