Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Pixie to TrixiParticles #82

Merged
merged 9 commits into from
Mar 20, 2023
Merged

Rename Pixie to TrixiParticles #82

merged 9 commits into from
Mar 20, 2023

Conversation

efaulhaber
Copy link
Member

No description provided.

sloede
sloede reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments where I think it might be useful to check consistency

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/callbacks/info.jl Show resolved Hide resolved
src/callbacks/solution_saving.jl Show resolved Hide resolved
src/containers/boundary_container.jl Show resolved Hide resolved
src/util.jl Outdated Show resolved Hide resolved
svchb
svchb reviewed Mar 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@efaulhaber efaulhaber requested review from sloede and svchb March 17, 2023 14:53
@efaulhaber efaulhaber enabled auto-merge (squash) March 17, 2023 14:53
@efaulhaber efaulhaber disabled auto-merge March 17, 2023 14:53
@efaulhaber efaulhaber requested review from sloede and ranocha March 20, 2023 15:31
sloede
sloede approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloede sloede enabled auto-merge (squash) March 20, 2023 15:41
ranocha
ranocha approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Project.toml Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
src/util.jl
Comment on lines +21 to +26
████████╗██████╗ ██╗██╗ ██╗██╗██████╗ █████╗ ██████╗ ████████╗██╗ ██████╗██╗ ███████╗███████╗
╚══██╔══╝██╔══██╗██║╚██╗██╔╝██║██╔══██╗██╔══██╗██╔══██╗╚══██╔══╝██║██╔════╝██║ ██╔════╝██╔════╝
██║ ██████╔╝██║ ╚███╔╝ ██║██████╔╝███████║██████╔╝ ██║ ██║██║ ██║ █████╗ ███████╗
██║ ██╔══██╗██║ ██╔██╗ ██║██╔═══╝ ██╔══██║██╔══██╗ ██║ ██║██║ ██║ ██╔══╝ ╚════██║
██║ ██║ ██║██║██╔╝ ██╗██║██║ ██║ ██║██║ ██║ ██║ ██║╚██████╗███████╗███████╗███████║
╚═╝ ╚═╝ ╚═╝╚═╝╚═╝ ╚═╝╚═╝╚═╝ ╚═╝ ╚═╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═════╝╚══════╝╚══════╝╚══════╝
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This becomes somewhat unreadable for me. No need to change it right now but maybe something to consider in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you prefer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 🚨 🚨 >>> 🚲 🏠 <<< 🚨 🚨 🚨

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's of course going to be bikeshedding. I just wanted to say once that this is quite a wall of text that becomes hard to parse for me. As I said, no need to change anything right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, no, you are absolutely right, I was just referring to @efaulhaber's innocent remark "What would you prefer?", which can spin easily out of control 😬

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a space to make it easier to read?

████████╗██████╗ ██╗██╗  ██╗██╗    ██████╗  █████╗ ██████╗ ████████╗██╗ ██████╗██╗     ███████╗███████╗
╚══██╔══╝██╔══██╗██║╚██╗██╔╝██║    ██╔══██╗██╔══██╗██╔══██╗╚══██╔══╝██║██╔════╝██║     ██╔════╝██╔════╝
   ██║   ██████╔╝██║ ╚███╔╝ ██║    ██████╔╝███████║██████╔╝   ██║   ██║██║     ██║     █████╗  ███████╗
   ██║   ██╔══██╗██║ ██╔██╗ ██║    ██╔═══╝ ██╔══██║██╔══██╗   ██║   ██║██║     ██║     ██╔══╝  ╚════██║
   ██║   ██║  ██║██║██╔╝ ██╗██║    ██║     ██║  ██║██║  ██║   ██║   ██║╚██████╗███████╗███████╗███████║
   ╚═╝   ╚═╝  ╚═╝╚═╝╚═╝  ╚═╝╚═╝    ╚═╝     ╚═╝  ╚═╝╚═╝  ╚═╝   ╚═╝   ╚═╝ ╚═════╝╚══════╝╚══════╝╚══════╝

Taken from https://patorjk.com/software/taag/#p=display&f=ANSI%20Shadow&t=Trixi%20Particles

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that.

@sloede sloede merged commit dcf1582 into trixi-framework:main Mar 20, 2023
@efaulhaber efaulhaber deleted the rename-trixiparticles branch March 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

@svchb svchb svchb approved these changes

@ranocha ranocha ranocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efaulhaber @sloede @svchb @ranocha