build: Add bundle.sh for deployment #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+52
to
+55
| install(FILES bundle.sh | ||
| DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
| ) | ||
|
|
There was a problem hiding this comment.
I'm not all that familiar with CMake. Do you know if we can rename this file as part of the installation process? My concern is that bundle.sh is very generic, and may conflict with other packages or scripts on the user's system. Whereas valijson-bundle.sh would be safer.
There was a problem hiding this comment.
@tristanpenman There is a RENAME option but I feel there is an element of obfuscation, why not name the original file as valijson-bundle.sh in the first place? Is there an operational/build requirement for it to be named bundle.sh ?
There was a problem hiding this comment.
That sounds like a good solution to me. Are you happy to push a rename change for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle.sh script is useful and should be included for deployment for people to use.