-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product tests for clickhouse clusters #10956
Add product tests for clickhouse clusters #10956
Conversation
Question
|
https://github.com/trinodb/trino/runs/5072994398?check_suite_focus=true I need help. How do I change
|
195836c
to
754b3ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the main motivations for ClickHouse product tests is #7600, but INSERT
statement failed as far as I confirmed. Do you have any idea why this happened? Invalid table definition?
trino> INSERT INTO clickhouse.default.test_distributed VALUES (1, 1, 1.0);
Query 20220207_015644_00008_bv244 failed: Failed to insert data: Code: 55, e.displayText() = DB::Exception: Method write is not supported by storage Distributed with more than one shard and no sharding key provided (version 21.3.2.5 (official build))
, server ClickHouseNode(addr=http:clickhouse:8124, db=default)@311454579
...ts-launcher/src/main/java/io/trino/tests/product/launcher/suite/suites/Suite7NonGeneric.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/clickhouse/TestInsert.java
Outdated
Show resolved
Hide resolved
...rces/docker/presto-product-tests/conf/environment/multinode-clickhouse/clickhouse.properties
Show resolved
Hide resolved
Yes, I assume you are using this PR configuration for ClickHouse cluster (3 shards 1 replica), I guess because you have a problem with the table definition (no sharding_key configured), when the cluster has multiple shards (>1), you must specify the shard key, you can refer to this document. Here is a description from the document that I quoted.
|
e9faa4b
to
81c741d
Compare
...roduct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Standard.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
81c741d
to
05a637c
Compare
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/ClickHouse.java
Outdated
Show resolved
Hide resolved
05a637c
to
c25bf44
Compare
Merged, thanks! |
Related issues, pull requests, and links
Fixes #8391
Documentation
No documentation is needed.
Release notes
No release notes entries required.