Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pnpm 9.14.2 #536

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Upgrade to pnpm 9.14.2 #536

merged 1 commit into from
Nov 28, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Oct 25, 2024

Description

Still have to test but saw the upgrade is needed in the log...

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2024
@ebyhr ebyhr requested a review from ytwp October 28, 2024 11:40
@willmostly
Copy link
Contributor

@mosabua do you want to convert this to a non-draft PR?

@mosabua mosabua marked this pull request as ready for review November 27, 2024 15:12
@mosabua
Copy link
Member Author

mosabua commented Nov 27, 2024

Let me test it out a bit later

@mosabua mosabua changed the title Upgrade node and pnpm Upgrade to pnpm 9.14.2 Nov 27, 2024
@mosabua
Copy link
Member Author

mosabua commented Nov 27, 2024

@willmostly .. I removed the node upgrade for now.. the pnpm upgrade works. So if you want to give it a final test and review we can merge.

For node we have to test separately.. I just got white screen and no UI. Also.. I filed #556

@mosabua mosabua merged commit 28545ee into trinodb:main Nov 28, 2024
2 checks passed
@mosabua mosabua deleted the web branch November 28, 2024 16:26
@github-actions github-actions bot added this to the 13 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants