Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http bugfix: case insensitive header equality was wrong #469

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Dec 23, 2023

and regression test added

http/src/headers.rs Fixed Show fixed Hide fixed
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f818162) 47.81% compared to head (5dd8311) 47.83%.

Files Patch % Lines
http/src/conn.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   47.81%   47.83%   +0.01%     
==========================================
  Files         169      169              
  Lines        6655     6659       +4     
==========================================
+ Hits         3182     3185       +3     
- Misses       3473     3474       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr force-pushed the http-bugfix-case-insensitive-header-equality branch from 6e71b9d to 5dd8311 Compare December 24, 2023 01:55
@jbr jbr merged commit 3396bc2 into main Dec 24, 2023
20 checks passed
@jbr jbr deleted the http-bugfix-case-insensitive-header-equality branch December 24, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant