Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websockets: make error handling more explicit #466

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Dec 21, 2023

closes #402

@jbr jbr force-pushed the websockets-improved-error-handling branch from 830934a to f9efbdd Compare December 24, 2023 02:35
@jbr jbr force-pushed the websockets-improved-error-handling branch from f9efbdd to f8ec62b Compare December 24, 2023 02:39
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (8a1ce38) 46.77% compared to head (38fbb8a) 46.71%.

Files Patch % Lines
websockets/src/json.rs 0.00% 15 Missing ⚠️
websockets/src/websocket_connection.rs 0.00% 9 Missing ⚠️
websockets/src/bidirectional_stream.rs 0.00% 6 Missing ⚠️
websockets/tests/json.rs 0.00% 4 Missing ⚠️
websockets/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   46.77%   46.71%   -0.07%     
==========================================
  Files         175      175              
  Lines        6815     6824       +9     
==========================================
  Hits         3188     3188              
- Misses       3627     3636       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr force-pushed the websockets-improved-error-handling branch from e225753 to 38fbb8a Compare December 24, 2023 03:21
@jbr jbr merged commit 2e4d630 into main Dec 24, 2023
20 checks passed
@jbr jbr deleted the websockets-improved-error-handling branch December 24, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report for trillium-websockets: send_bytes and send_text ignore errors
1 participant