Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client bugfix: handle the case when we have already buffered a full http response #445

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Nov 27, 2023

No description provided.

Copy link
Contributor

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbr jbr force-pushed the client-bug-rnrn-in-buffer branch from 48c488c to a6d3b39 Compare November 27, 2023 20:27
client/src/conn.rs Fixed Show fixed Hide fixed
@jbr jbr force-pushed the client-bug-rnrn-in-buffer branch from a6d3b39 to 7497e02 Compare November 27, 2023 20:33
@jbr jbr force-pushed the client-bug-rnrn-in-buffer branch from 7497e02 to 9640306 Compare November 27, 2023 21:07
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b6880ff) 47.71% compared to head (9640306) 47.96%.

Files Patch % Lines
client/src/conn.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   47.71%   47.96%   +0.25%     
==========================================
  Files         169      169              
  Lines        6543     6569      +26     
==========================================
+ Hits         3122     3151      +29     
+ Misses       3421     3418       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr merged commit e83c64a into main Nov 27, 2023
20 checks passed
@jbr jbr deleted the client-bug-rnrn-in-buffer branch November 27, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants