Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web][UMA-1123] WalletConnect reports unsupported method correctly #2380

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[Web][UMA-1123] WalletConnect reports unsupported method correctly #2380

merged 1 commit into from
Feb 13, 2025

Conversation

dianasavvatina
Copy link
Contributor

@dianasavvatina dianasavvatina commented Feb 11, 2025 •
edited
Loading

Proposed changes

UMA-1123

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  1. connect Tezos Provider Test dApp PR#697
  2. Run Increase paid storage
  3. See the reported error

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now
image image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:11pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:11pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:11pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:11pm

@dianasavvatina dianasavvatina force-pushed the UMA-1123/wc-bug-unsupported-method-reported-to-dapp branch from 56a0f8e to 74ee934 Compare February 11, 2025 15:06
@dianasavvatina dianasavvatina force-pushed the UMA-1123/wc-bug-unsupported-method-reported-to-dapp branch from 74ee934 to 4187971 Compare February 13, 2025 10:25
OKendigelyan
OKendigelyan approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dianasavvatina dianasavvatina force-pushed the UMA-1123/wc-bug-unsupported-method-reported-to-dapp branch from 4187971 to 66bf07d Compare February 13, 2025 13:57
@dianasavvatina dianasavvatina enabled auto-merge (rebase) February 13, 2025 13:57
@dianasavvatina dianasavvatina merged commit dee84e9 into main Feb 13, 2025
10 checks passed
@dianasavvatina dianasavvatina deleted the UMA-1123/wc-bug-unsupported-method-reported-to-dapp branch February 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OKendigelyan OKendigelyan OKendigelyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianasavvatina @OKendigelyan