feat: add error state for RBF when previous transaction gets mined befor user sends the modal #16878
Conversation
WalkthroughThis pull request introduces a specialized mechanism for handling errors in replace-by-fee transactions. It adds a new thunk ( Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🚀 Expo preview is ready!
|
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
3 times, most recently
from
6d7a742 to
cae81c4
Compare
| @@ -227,7 +227,13 @@ export const signAndPushSendFormTransactionThunk = createThunk( | |||
| ); | |||
|
|
|||
| if (isRejected(signResponse)) { | |||
| // close modal manually since UI.CLOSE_UI.WINDOW was blocked | |||
| // Do not close the modal, as we need that modal to display the error state. | |||
| if (signResponse.payload?.message === RBF_ERROR_ALREADY_MINED) { | |||
There was a problem hiding this comment.
This is ugly hack, that unfortunately have to employ. The similar mechanism is used in wallet-switcher.
This is currently the only way, how to send some date from place where cancel on device happen to the place where result of cancelled operation is awaited
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts (1)
9-20: Consider adding error logging.While the error handling flow is correct, consider adding error logging to help with debugging and monitoring.
export const replaceByFeeErrorThunk = createThunk( `${MODULE_PREFIX}/replaceByFeeErrorThunk`, (_, { dispatch }) => { + console.error('RBF transaction failed: Original transaction already mined'); TrezorConnect.cancel(RBF_ERROR_ALREADY_MINED); dispatch( openModal({ type: 'review-transaction-rbf-previous-transaction-mined-error', }), ); }, );packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts (1)
10-33: Consider adding early returns for better readability.The middleware implementation is correct but could be more readable with early returns.
export const replaceByFeeErrorMiddleware = (api: MiddlewareAPI<Dispatch, AppState>) => (next: Dispatch) => (action: Action): Action => { next(action); - if (transactionsActions.addTransaction.match(action)) { - const { transactions } = action.payload; + if (!transactionsActions.addTransaction.match(action)) { + return action; + } - const precomposedTx = api.getState().wallet.send?.precomposedTx; + const { transactions } = action.payload; + const precomposedTx = api.getState().wallet.send?.precomposedTx; - if (precomposedTx !== undefined && isRbfTransaction(precomposedTx)) { - const addedTransaction = transactions.find( - tx => tx.txid === precomposedTx.prevTxid, - ); + if (!precomposedTx || !isRbfTransaction(precomposedTx)) { + return action; + } - if (addedTransaction !== undefined && addedTransaction.blockHeight !== undefined) { - api.dispatch(replaceByFeeErrorThunk()); - } - } + const addedTransaction = transactions.find( + tx => tx.txid === precomposedTx.prevTxid, + ); + + if (addedTransaction?.blockHeight !== undefined) { + api.dispatch(replaceByFeeErrorThunk()); } return action; };packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx (1)
19-19: Consider adding prop types validation.While the implementation is correct, consider adding prop-types validation for better runtime type checking.
+import PropTypes from 'prop-types'; export const TransactionReviewModal = ({ type, decision }: TransactionReviewModalProps) => { // ... existing code ... }; +TransactionReviewModal.propTypes = { + type: PropTypes.oneOf(['review-transaction', 'sign-transaction', 'review-transaction-rbf-previous-transaction-mined-error']).isRequired, + decision: PropTypes.shape({ + resolve: PropTypes.func, + reject: PropTypes.func, + }), +};Also applies to: 38-38
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (1)
176-216: Consider extracting button variants to constants.While the BottomContent component is well-structured, the button variants ('tertiary') could be extracted to named constants for better maintainability.
+const BUTTON_VARIANTS = { + TERTIARY: 'tertiary', +} as const; const BottomContent = () => { if (isRbfConfirmedError) { return ( - <NewModal.Button variant="tertiary" onClick={onCancel}> + <NewModal.Button variant={BUTTON_VARIANTS.TERTIARY} onClick={onCancel}> <Translation id="TR_CLOSE" /> </NewModal.Button> ); } // ... rest of the code };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts(1 hunks)packages/suite/src/actions/wallet/send/sendFormThunks.ts(2 hunks)packages/suite/src/actions/wallet/send/sendThunksConsts.ts(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx(6 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewSummary.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx(0 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx(1 hunks)packages/suite/src/middlewares/wallet/index.ts(2 hunks)packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts(1 hunks)packages/suite/src/support/messages.ts(1 hunks)suite-common/suite-types/src/modal.ts(1 hunks)suite-common/wallet-core/src/transactions/transactionsActions.ts(1 hunks)
💤 Files with no reviewable changes (1)
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx
✅ Files skipped from review due to trivial changes (1)
- packages/suite/src/actions/wallet/send/sendThunksConsts.ts
🧰 Additional context used
📓 Learnings (1)
packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx (1)
Learnt from: Lemonexe
PR: trezor/trezor-suite#16525
File: packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx:60-76
Timestamp: 2025-02-03T17:19:25.374Z
Learning: The CancelTransactionModal component should handle error states from composeCancelTransactionThunk by showing CancelTransactionFailed component and disable the cancel button during loading.
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: build-web
- GitHub Check: prepare_android_test_app
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: EAS Update
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: build-web
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
🔇 Additional comments (19)
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewSummary.tsx (2)
30-30: LGTM! MakingonDetailsClickoptional improves component flexibility.The change to make
onDetailsClickoptional is a good practice as it allows the component to handle states where the details interaction isn't needed.
110-120: LGTM! Proper guard against undefined handler.The condition is well-structured with:
- Efficient check ordering (cheap check first)
- Proper guard against undefined handler
- Consistent with the optional prop type change
packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts (1)
7-7: LGTM! Clear and descriptive error constant.The error constant follows naming conventions and clearly describes the error scenario.
packages/suite/src/middlewares/wallet/index.ts (1)
18-18: LGTM! Middleware properly integrated.The replaceByFeeErrorMiddleware is correctly imported and added to the middleware chain.
Also applies to: 32-32
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx (1)
11-17: LGTM! Clear type definition.The type definition is well-structured and properly includes the new RBF error case.
suite-common/wallet-core/src/transactions/transactionsActions.ts (2)
24-38: Well-structured type definitions!The new type definitions improve type safety and code maintainability by clearly defining the structure of the action's parameters and return value.
47-47: Clean type implementation!Good use of the newly defined types in the action creator's signature.
packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx (2)
12-30: Well-organized type and mapping definitions!Good use of TypeScript's Record type for mapping different scenarios to their respective titles, descriptions, and help links. The type parameter effectively handles both RBF and cancel transaction cases.
32-51: Clean and consistent UI implementation!The component follows good UI/UX practices:
- Clear visual hierarchy with warning icon
- Consistent spacing using theme values
- Helpful links to documentation
packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx (1)
24-24: Good integration of the new error component!The replacement of CancelTransactionFailed with ReplaceByFeeFailedOriginalTxConfirmed aligns with the learning about error handling in the modal. The implementation correctly handles the confirmed transaction state.
Also applies to: 102-104
suite-common/suite-types/src/modal.ts (1)
60-63: Well-defined user context type!The new type 'review-transaction-rbf-previous-transaction-mined-error' with optional decision property aligns perfectly with the PR's objective of handling RBF scenarios when a block is mined while the modal is open.
packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx (1)
109-110: LGTM! Clean addition of RBF error handling.The new case for handling RBF errors when previous transactions are mined follows the existing pattern and maintains consistency by reusing the TransactionReviewModal component.
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (4)
48-49: LGTM! Well-documented prop addition.The comment about potential future extension into a generic error type shows good foresight for maintainability.
106-115: LGTM! Clear error handling logic.The onCancel function cleanly handles both RBF error and normal cases, maintaining proper state cleanup.
218-240: LGTM! Clean component extraction.The Content component effectively encapsulates rendering logic and improves code organization.
244-254: LGTM! Appropriate conditional rendering.The ConfirmOnDevice component is correctly hidden during RBF error state, improving user experience.
packages/suite/src/actions/wallet/send/sendFormThunks.ts (2)
36-37: LGTM! Clear imports for error handling.The imports for RBF error constant and module prefix improve code organization.
230-237: LGTM! Well-documented error handling.The error handling logic clearly distinguishes between RBF mining errors and other cases, with helpful comments explaining the flow.
packages/suite/src/support/messages.ts (1)
6445-6462: LGTM! New error messages for transaction cancellation/replacement flows.The new message definitions are well-structured and follow the existing conventions. The messages clearly explain to users why their transaction cancellation or replacement failed (because the transaction was already confirmed on the network).
.../components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx
Show resolved
Hide resolved
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
from
cae81c4 to
c9e26c9
Compare
| import { Translation, TranslationKey } from '../../../../Translation'; | ||
| import { TrezorLink } from '../../../../TrezorLink'; | ||
|
|
||
| type ReplaceByFeeFailedOriginalTxConfirmedParams = { |
There was a problem hiding this comment.
tiny nit: Props, not Params
| @@ -42,12 +44,16 @@ type TransactionReviewModalContentProps = { | |||
| decision: Deferred<boolean, string | number | undefined> | undefined; | |||
| txInfoState: SendState | StakeState; | |||
| cancelSignTx: () => void; | |||
|
|
|||
| // Just bool for now, but could be extended into generic error in the future | |||
There was a problem hiding this comment.
I don't think this comment is needed - it's trivial
| ); | ||
| } | ||
|
|
||
| if (!areDetailsVisible && isBroadcastEnabled) { |
There was a problem hiding this comment.
When I look at the original condition it says
!areDetailsVisible && (isBroadcastEnabled ? <JSX1 /> : <JSX2 />)
You did not keep the same logic, is this intentional?
I believe this upholds original behavior:
| if (!areDetailsVisible && isBroadcastEnabled) { | |
| if (areDetailsVisible) return null; | |
| if (isBroadcastEnabled) { |
There was a problem hiding this comment.
yes, you're right, nice catch, thank you, fixed
.../components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx
Show resolved
Hide resolved
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
from
c9e26c9 to
9f1c31a
Compare
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
from
9f1c31a to
c87c86c
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (3)
104-113: Consider restructuring the onCancel function for better readability.While the logic is correct, the function could be more readable by handling the normal case first.
Consider this refactor:
const onCancel = () => { - if (isRbfConfirmedError) { - dispatch(modalActions.onCancel()); - } - if (isActionAbortable || serializedTx) { cancelSignTx(); decision?.resolve(false); } + + if (isRbfConfirmedError) { + dispatch(modalActions.onCancel()); + } };
174-218: Consider moving BottomContent outside the main component.While the component logic is correct, it's currently recreated on every render of the parent component. Moving it outside would improve performance.
Consider this approach:
const BottomContent: React.FC<{ isRbfConfirmedError?: boolean; areDetailsVisible: boolean; isBroadcastEnabled: boolean; serializedTx?: { tx: string }; isSending: boolean; onCancel: () => void; handleSend: () => void; handleCopy: () => void; handleDownload: () => void; actionLabel: string; }> = ({ /* props */ }) => { // existing implementation };
220-242: Consider moving Content outside the main component.Similar to BottomContent, this component would benefit from being moved outside the parent component to prevent unnecessary recreations.
Consider this approach:
const Content: React.FC<{ areDetailsVisible: boolean; isRbfConfirmedError?: boolean; precomposedTx: PrecomposedTransaction; serializedTx?: { tx: string }; // ... other required props }> = ({ /* props */ }) => { // existing implementation };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts(1 hunks)packages/suite/src/actions/wallet/send/sendFormThunks.ts(2 hunks)packages/suite/src/actions/wallet/send/sendThunksConsts.ts(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx(6 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx(0 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx(1 hunks)packages/suite/src/middlewares/wallet/index.ts(2 hunks)packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts(1 hunks)packages/suite/src/support/messages.ts(1 hunks)suite-common/suite-types/src/modal.ts(1 hunks)suite-common/wallet-core/src/transactions/transactionsActions.ts(1 hunks)
💤 Files with no reviewable changes (1)
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx
🚧 Files skipped from review as they are similar to previous changes (12)
- packages/suite/src/actions/wallet/send/sendThunksConsts.ts
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx
- suite-common/suite-types/src/modal.ts
- packages/suite/src/middlewares/wallet/index.ts
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx
- packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx
- packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx
- suite-common/wallet-core/src/transactions/transactionsActions.ts
- packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts
- packages/suite/src/actions/wallet/send/sendFormThunks.ts
- packages/suite/src/support/messages.ts
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: build-web
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: build-web
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: prepare_android_test_app
- GitHub Check: EAS Update
🔇 Additional comments (2)
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (2)
36-36: LGTM! Props and imports are well-structured.The new import and prop addition are correctly implemented to support the RBF error state handling.
Also applies to: 47-47
244-279: LGTM! Clean and well-structured conditional rendering.The changes effectively handle the RBF error state while maintaining good separation of concerns. The conditional rendering is clear and follows React best practices.
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
from
c87c86c to
ab34593
Compare
…for user sends the modal
peter-sanderson
force-pushed
the
cancel-transaction-screen-2-error
branch
from
ab34593 to
5933cb7
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (1)
104-113: Consider simplifying the onCancel function.The function can be made more concise by handling both cases together.
- const onCancel = () => { - if (isRbfConfirmedError) { - dispatch(modalActions.onCancel()); - } - - if (isActionAbortable || serializedTx) { - cancelSignTx(); - decision?.resolve(false); - } - }; + const onCancel = () => { + if (isRbfConfirmedError) { + dispatch(modalActions.onCancel()); + return; + } + + if (isActionAbortable || serializedTx) { + cancelSignTx(); + decision?.resolve(false); + } + };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts(1 hunks)packages/suite/src/actions/wallet/send/sendFormThunks.ts(2 hunks)packages/suite/src/actions/wallet/send/sendThunksConsts.ts(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx(6 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx(0 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx(2 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx(1 hunks)packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx(1 hunks)packages/suite/src/middlewares/wallet/index.ts(2 hunks)packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts(1 hunks)packages/suite/src/support/messages.ts(1 hunks)suite-common/suite-types/src/modal.ts(1 hunks)suite-common/wallet-core/src/transactions/transactionsActions.ts(1 hunks)
💤 Files with no reviewable changes (1)
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionFailed.tsx
🚧 Files skipped from review as they are similar to previous changes (12)
- packages/suite/src/actions/wallet/send/sendThunksConsts.ts
- packages/suite/src/middlewares/wallet/index.ts
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/UserContextModal.tsx
- packages/suite/src/middlewares/wallet/replaceByFeeErrorMiddleware.ts
- suite-common/suite-types/src/modal.ts
- packages/suite/src/actions/wallet/send/replaceByFeeErrorThunk.ts
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ReplaceByFeeFailedOriginalTxConfirmed.tsx
- packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModal.tsx
- packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/CancelTransaction/CancelTransactionModal.tsx
- suite-common/wallet-core/src/transactions/transactionsActions.ts
- packages/suite/src/actions/wallet/send/sendFormThunks.ts
- packages/suite/src/support/messages.ts
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: EAS Update
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: prepare_android_test_app
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: build-web
- GitHub Check: build-web
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: Analyze with CodeQL (javascript)
🔇 Additional comments (4)
packages/suite/src/components/suite/modals/ReduxModal/TransactionReviewModal/TransactionReviewModalContent.tsx (4)
25-25: LGTM! Props and imports are well-organized.The new imports and prop
isRbfConfirmedErrorare correctly added to support the RBF error state handling.Also applies to: 36-36, 47-47
174-218: LGTM! Well-structured component extraction.The
BottomContentcomponent cleanly handles different modal states and improves code organization.
220-242: LGTM! Clean component extraction.The
Contentcomponent effectively manages different view states and maintains good separation of concerns.
244-279: LGTM! Clean and maintainable render logic.The main render logic effectively uses the extracted components and correctly handles the RBF error state.
Partially addresses #16875
This PR handles the situation in RBF flow, when block is mined when modal is opened.
Case
#1Case
#2