Avoid possible nil pointer errors (#24)

treydock · May 12, 2023 · 640ac7e · 640ac7e
1 parent 4f5fed9
commit 640ac7e
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/cgroup_exporter.go b/cgroup_exporter.go
@@ -329,7 +329,15 @@ func (e *Exporter) getMetrics(name string, pids map[string][]int) (CgroupMetric,
 		metric.err = true
 		return metric, err
 	}
-	stats, _ := ctrl.Stat(cgroups.IgnoreNotExist)
+	stats, err := ctrl.Stat(cgroups.IgnoreNotExist)
+	if err != nil {
+		level.Error(e.logger).Log("msg", "Failed to stat cgroups", "path", name, "err", err)
+		return metric, err
+	}
+	if stats == nil {
+		level.Error(e.logger).Log("msg", "Cgroup stats are nil", "path", name)
+		return metric, err
+	}
 	if stats.CPU != nil {
 		if stats.CPU.Usage != nil {
 			metric.cpuUser = float64(stats.CPU.Usage.User) / 1000000000.0