Adapt to deprecation warnings in Python 3.14 alphas #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per comments, we needed to set and restore the event loop policy in Python 3.4, but it no longer seems to be necessary (and raises DeprecationWarnings in Python 3.14).
Accessing the base policy classes now triggers a deprecation warning so we must use our own getattr hook to avoid it except when needed.
This causes deprecation warnings in Python 3.14
This is a temporary measure to get CI passing while the fate of these deprecation warnings is decided in python/cpython#130322
Alpha 5 has a bug that affects us, so pin alpha 4 until 6 is released. python/cpython#130380
bdarnell
force-pushed
the
deprecations-314
branch
from
b8825d2 to
5eea953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14 deprecates the asyncio event loop policy system, so make (most of) the necessary changes.
The deprecation of set_event_loop is extremely disruptive to AsyncTestCase, so I've asked if it can remain undeprecated in python/cpython#130322. The testing.py changes are temporary until this is resolved.
Fixes #3458