Add windows arm64 build #3457
Merged
Add windows arm64 build #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the python 3.14 tests are failing due to a depreciation warning. ( |
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Feb 20, 2025
from tornadoweb#3457 and if this works i'll merge that one, i just need it on my fork to test the ci build
|
Thanks! I've run a test of the build workflow with this change to make sure it doesn't slow things down too much and it looks fine: it adds about 75 seconds to the windows build which previously took about 10 minutes. This is currently irrelevant to the total build time because the linux builds take 22 minutes (although this will change when I get a linux arm build runner so we don't have to build and test arm in emulation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to cross-compile a windows arm64 wheel. (#3456)
While this cannot be tested in the CI until GitHub starts supporting Windows arm64 machines for open source projects, I did test the wheel this produced locally on an arm64 Windows machine and it passed all tests.