twisted: Delete TwistedResolver class #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was deprecated and slated for deletion in Tornado 7.0. However, it has become broken due to the adoption of RFC 8482 (which limits the use of the ANY query type in DNS) and it now fails for most domain names (with the exception of localhost). The upstream issue twisted/twisted#10062 has been open for years which is a pretty good sign that no one is depending on this class and it's safe to remove it ahead of schedule. This class was primarily intended to provide thread-free non-blocking DNS resolution. If that is still required, `tornado.platform.caresresolver` is the next best option, although it has its own limitations which differ from TwistedResolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was deprecated and slated for deletion in Tornado 7.0. However, it has become broken due to the adoption of RFC 8482 (which limits the use of the ANY query type in DNS) and it now fails for most domain names (with the exception of localhost). The upstream issue twisted/twisted#10062 has been open for years which is a pretty good sign that no one is depending on this class and it's safe to remove it ahead of schedule.
This class was primarily intended to provide thread-free non-blocking DNS resolution. If that is still required,
tornado.platform.caresresolveris the next best option, although it has its own limitations which differ from TwistedResolver.