Skip to content

Commit

Permalink
ci: Remove persist-credentials from our CI workflows
Browse files Browse the repository at this point in the history
This mitigates a potential security risk identified by zizmor.
  • Loading branch information
bdarnell committed Oct 30, 2024
1 parent 385fd88 commit dc29f60
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
name: Install Python
with:
Expand All @@ -51,6 +53,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
name: Install Python
with:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
name: Install Python
with:
Expand Down Expand Up @@ -65,6 +67,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
name: Install Python
with:
Expand All @@ -88,6 +92,8 @@ jobs:
runs-on: windows-2022
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
name: Install Python
with:
Expand Down

0 comments on commit dc29f60

Please sign in to comment.