Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lix (Nix fork) #952

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

9999years
Copy link
Contributor

What does this PR do

Lix is a fork of Nix 2.18 focused on maintainability and user experience. It has a different format for the version, to distinguish it from CppNix:

$ nix --version
nix (Lix, like Nix) 2.91.0

This PR adjusts the Nix version parsing code to account for that, and also removes a few panic!()s along the way.

See: https://lix.systems/

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

Lix is a fork of Nix 2.18 focused on maintainability and user
experience. It has a different format for the version, to distinguish it
from CppNix:

    $ nix --version
    nix (Lix, like Nix) 2.91.0

See: <https://lix.systems/>
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I wonder if we should update the Separator in line 433?

@9999years
Copy link
Contributor Author

@SteveLauC I think that's OK, Lix is Nix, it's just based on an older version of Nix so the CLI/version numbers have some different conventions.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC merged commit 9ffdc96 into topgrade-rs:main Oct 18, 2024
12 checks passed
@9999years 9999years deleted the support-lix branch December 6, 2024 04:23
@9999years
Copy link
Contributor Author

Hey, quick bump — could we get a release for this? Topgrade crashes every time it hits the Nix step on my machine. Thanks so much!

@SteveLauC
Copy link
Member

Hey, quick bump — could we get a release for this? Topgrade crashes every time it hits the Nix step on my machine. Thanks so much!

Sure, let me take a look and drop a release:)

@SteveLauC
Copy link
Member

v16.0.2 released

@9999years
Copy link
Contributor Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants