-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security questionnaire answers #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianliebel
requested changes
Jan 21, 2025
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
Co-authored-by: Christian Liebel <[email protected]>
tomayac
commented
Jan 21, 2025
christianliebel
approved these changes
Jan 21, 2025
christianliebel
requested changes
Jan 21, 2025
security-privacy-questionnaire.md
Outdated
|
||
## 02. Do features in your specification expose the minimum amount of information necessary to implement the intended functionality? | ||
|
||
|
||
Yes, after explicit user consent, the API exposes only the existence of a file with a known hash and provides read access to it. No additional metadata nor write access is exposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? The API also allows write access, at least once.
tomayac
commented
Jan 21, 2025
@christianliebel Thanks for the review so far. If you have a moment, could you also see the new security and privacy considerations that I have added in 495572c. |
tomayac
commented
Jan 21, 2025
beaufortfrancois
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a separate questionnaire and both a security and privacy consideration section.
Things this needs to respond to: