mikrotikapi.py: Add SSL cert verification #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only adds the minimal ssl cert verification, disabling the hostname check which I think is not so useful anwyays on internal routers/switches which commonly will not have externally routable hostnames and disables the strict checking to allow easier use of self made CAs without intermediate CAs restricting key usage etc...
|
The black verification fails do not seem related to my PR, it's passing on the mikrotikapi.py entirely with or without my changes |
|
What do you mean about minimal cert verification? |
|
Yes, currently it'll use SSL but not verify the remote end which is a bit sad since if you bothered to issue certs on your network devices you have a CA, so you might as well import it in HA and check you're talking to the device you expected!
By minimal I mean disabling the strict checking, as to avoid all the key usage mess etc. To be honest maybe I'm being lazy there but i figured it was a reasonable compromise.
…On 15 January 2025 15:06:18 CET, Tomaae ***@***.***> wrote:
What do you mean about minimal cert verification?
Right now it is set to allow encrypted communication for people who want that extra layer.
We obviously dont want hostname verification for network devices, no argument there.
--
Reply to this email directly or view it on GitHub:
#396 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
It is doable, but it would probably break many current setups. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This only adds the minimal ssl cert verification, disabling the hostname check which I think is not so useful anwyays on internal routers/switches which commonly will not have externally routable hostnames and disables the strict checking to allow easier use of self made CAs without intermediate CAs restricting key usage etc...
Type of change
One could argue not verifying SSL certs is a bug but I guess this was done on purpose and I didn't hide it behind a config flag...
Additional information
Checklist