-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Relax MSRV #983
chore: Relax MSRV #983
Conversation
0fc1dc4
to
c3b1610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the whole repo at the same MSRV. With the removal of which
in #962 the MSRV of the published crates can be lowered to rust 1.65. Would that be enough for your use case?
I suggest to only do a CI build with stable toolchain (so remove the 1.70 toolchain) and to add your proposed MSRV check.
Since checking MSRV for different crates can be performed easily as this pull request describes, and the crates except for |
8a78c81
to
7e4f10b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stick to my position. I want to keep the whole repo at the same MSRV. I believe the MSRV of the crates can be lowered to rust 1.65.
I opened a new PR with only the CI improvement: #1057 |
The CI improvement from this PR is merged. I won't accept multiple MSRV versions in one repo. If you want to lower the MSRV of the whole repo, you are welcome to reopen. |
Relaxes MSRV which are bumped in #982. As the use of
prost-build
can be separated to the different build process, it is too strict to set the same MSRV ofprost-build
to the other crates for users.cargo-hack
's--rust-version
option can be used to perform checking different MSRVs on the project crates.