-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #485: add Watchman monitoring url #500
base: develop
Are you sure you want to change the base?
fixes #485: add Watchman monitoring url #500
Conversation
}, | ||
'watchman': { | ||
'handlers': ['console'], | ||
'level': 'DEBUG', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should maybe use os.getenv('DJANGO_LOG_LEVEL', 'INFO')
like above rather than everything at DEBUG level? Does this cause a lot of log messages when accessing watchman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these debug logs when the /watchman/
url is called
ccm_web | [2025-02-13 21:48:46 +0000] [DEBUG] [decorators.py:26] Checking '_check_database' for 'default'
ccm_web | [2025-02-13 21:48:46 +0000] [DEBUG] [decorators.py:26] Checking '_check_database' for 'default'
ccm_web | [2025-02-13 21:48:46 +0000] [DEBUG] [decorators.py:26] Checking '_check_cache' for 'default'
ccm_web | [2025-02-13 21:48:46 +0000] [DEBUG] [decorators.py:26] Checking '_check_cache' for 'default'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why duplicate logs of same check, since these are debug might now be noise in prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we'd want it to be able to run at INFO
or WARNING
probably in prod. Just seemed fine to match the DJANGO level.
I see this working when called
|
Zabbix is currently using |
test plan: check to see if the monitoring endpoint is available using your local ngrok or loophole URL at /watchman/
The requested resource should be a report and response on the status of database, cache, etc.