Add support of extend and block in EJS #142

ictliujie · 2013-10-14T04:37:31Z

@visionmedia, fyi:
Add features of extend and block, which could support
(1) multilayer inheritance, fully support layout in EJS.
(2) Also could work with include.
The examples and test has also been add!

add features of extend and block, could support multilayer inheritance, could fully support the layout in EJS. Also could work with include. The examples and test has also been add!

the test in benchmark shows that the layout using extend is 33% faster than that using include

izidorome · 2013-11-22T13:05:27Z

+1

welkang · 2013-11-23T17:00:24Z

How to use the extend and block feature?

welkang · 2013-11-23T17:03:33Z

Oh, I found it.
Extend file with <%+ file-to-be-extended %>
Blocks <%block blockname%>content comes here<%/block%>, cooperate with extend

ictliujie · 2013-11-25T02:58:41Z

@welkang, yes, that is the way. You could also refer to the examples in the source code. Have fun

onurozkan · 2013-11-26T17:54:23Z

+1

tj · 2013-11-26T18:49:12Z

lib/ejs.js

-
+
+  //the extend symbol must be in the first place of the file if exist
+  if(str.trim().indexOf(open + "+") == "0"){


the rest looks fine and the tests are good but we'd definitely want to try and make this chunk more declarative it's not super obvious and it's a lot to cram into the one function

yes, you are right. I used too many temp variables in the function. I'll spend my weekend to optimize the code, make it more declarative. we can talt about it later.
The extend feature is very useful and necessary. So I advise strongly that it could be merged into the trunk sooner or later. thanks!

there's also #147 which is similar, it would be great if you could maybe check out that PR and help review :D at a glance they both look really similar

ok, I'd like to :D

reorganize the code related to extend , make it more declarative

AdamPuzio · 2013-12-12T19:45:26Z

I am excited about this feature returning to EJS, but I'd like to point out that 'extend' and 'layout' are really two different features. With 'layout', you are requesting that the entire content of the current view be wrapped in a particular view. With 'extend', you are instead defining certain blocks that will override the corresponding blocks in the extended view. While possible to do with both, generally extended views can stack many generations deep, while layouts typically don't. While I would love to see both features in EJS, I think it's important to recognize the commonalities and differences between them. Both this and #147 seem to be describing 'extend', but #147 refers to it as 'layout'.

Also, while I'm here, I may as well mention a feature with 'extend' that I've seen (and love) in other template engines: the ability to supplement content in a block, either by explicitly defining 'prepend' or 'append' in the tag or by defining a sub-tag within the block that defines where the ancestor's content should live.

ictliujie · 2013-12-13T12:37:48Z

yes, I agree that extend and layout are two different features. And in practice,
(1) we usually use the feature of extend to implement the layout
(2) I don't recommend that multi-layer extend in EJS(or any other template engine), evet if it has been supported. Actually 2-3 layers is enough, which is more clear and efficient.
(3) prepend & append are good features in extend. Considering the great Filter functions in EJS has come up to the two features, I don't realize them in extend.
@AdamPuzio

mostly-magic · 2013-12-13T17:41:00Z

@AdamPuzio You're right, #147 is describing "extend" as well. My use of the term layout is just my own improper use of terminology. I'll try to stop that to avoid confusion :-).

I don't see the layout feature you describe as anything more than a specialized use case of extend. I agree with @ictliujie that I don't typically recommend more than 2-3 layers in extend, though maybe your needs do call for it.

I like the idea of prepend/append, and @ictliujie notion of using Filters seems promising. I'll give it some thought for #147. @visionmedia Is this something you would want in an initial launch of templates?

izidorome · 2014-01-22T20:27:06Z

Any news on this?

caspervonb · 2014-02-05T00:09:14Z

+1

@visionmedia plans to merge this?

ilanbiala · 2014-04-16T20:28:00Z

+1

sjlu · 2014-05-27T02:10:49Z

+1

hburrows · 2014-05-29T15:01:59Z

+1

richgong · 2014-06-05T23:12:10Z

+1

ilanbiala · 2014-06-05T23:27:39Z

@visionmedia It's been a while since EJS has received any development attention. Are you going to allow people to start taking over this project or is EJS dying?

richgong · 2014-06-13T18:51:59Z

Hey guys. I found the extend and block feature I wanted here: https://github.com/RandomEtc/ejs-locals
Just do: npm install ejs-locals
layout = extend
block = block

flipflopsimsommer · 2014-06-20T19:58:14Z

@freeauto is the also a block append / prepend feature?
i'm looking for it since weeks.

Vadorequest · 2014-07-19T07:31:46Z

@ilanbiala I see many pull request waiting for months. I'm going to find another template node module, EJS is clearly not good enough, there is not even what are the basics for me, coming from Ruby I have the feeling that I can't work with EJS.

mde · 2014-07-19T18:08:11Z

@Vadorequest, I am the new maintainer of this module, and I hope to get things moving a bit faster once I've familiarized myself more with the codebase.

I am also the maintainer of the Geddy Web app framework for Node (http://geddyjs.org/), which has its own bundled EJS implementation (https://github.com/geddy/geddy/blob/master/lib/template/engines/ejs.js) that also has a couple of features missing here. I hope you'll be patient and give me a chance to ramp up.

As far as "being from the Ruby world," EJS is almost precisely the same as ERB, which was the default in Rails for years. (I haven't followed to see if they've switched to HAML recently or not.)

Vadorequest · 2014-07-19T18:31:34Z

@mde Nice! Do you have any idea about what you will start to add/fix in EJS?

mebibou · 2014-09-20T17:28:00Z

+1

JeffSpies · 2014-09-28T14:55:43Z

Very interested in this particular functionality. +1

Just to add to the discussion https://github.com/gett/pejs does some of this as well.

ilanbiala · 2014-09-28T15:05:11Z

@Vadorequest @mde nothing's moved since May 1st, when TJ made the last commit. I've pretty much moved away from EJS, and there are plenty of other template engines out there.

Vadorequest · 2014-09-28T15:23:03Z

Yeah... I keep an eye on it but I don't have much faith in EJS I have to
say. That's really bad because that's the default template engine of
Sails.js, a great framework and because I've worked with it deep into my
architecture and don't want to change everything, but it doesn't work
correctly so ... Just borring. Hate working with stuff that doesn't work
correctly...

calidion · 2015-12-21T18:26:54Z

what is the progress on this?

huxia · 2017-04-17T11:19:30Z

guys, here is my block implementation for the new ejs.
mde/ejs#252

rossrossp · 2017-07-03T17:23:21Z

Is anything happening with this?

MohitKumar1991 · 2017-07-07T09:08:29Z

Has this support been added ?

mde · 2017-07-07T14:53:17Z

This version of EJS is no longer maintained. The current version, installable via NPM, is here: https://github.com/mde/ejs

ictliujie added 3 commits October 14, 2013 11:24

Add support of extend and block in EJS

35bf020

add features of extend and block, could support multilayer inheritance, could fully support the layout in EJS. Also could work with include. The examples and test has also been add!

modify the descriptions of extend in the readme.md

ffba40a

Add the comparison between extend and include

8973735

the test in benchmark shows that the layout using extend is 33% faster than that using include

tj reviewed Nov 26, 2013
View reviewed changes

mostly-magic mentioned this pull request Nov 26, 2013

Adds support of layout and blocks to EJS #147

Closed

reorganize the code related to extend

3e3fa8c

reorganize the code related to extend , make it more declarative

Vadorequest mentioned this pull request Mar 21, 2015

Support for blocks mde/ejs#78

Closed

dev-rke mentioned this pull request Jan 27, 2016

Templates lega911/angular-light#131

Closed

huxia mentioned this pull request Apr 17, 2017

block/template/extend support for ejs mde/ejs#252

Open

mde closed this Jul 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support of extend and block in EJS #142

Add support of extend and block in EJS #142

ictliujie commented Oct 14, 2013

izidorome commented Nov 22, 2013

welkang commented Nov 23, 2013

welkang commented Nov 23, 2013

ictliujie commented Nov 25, 2013

onurozkan commented Nov 26, 2013

tj Nov 26, 2013

ictliujie Nov 28, 2013

tj Nov 28, 2013

ictliujie Nov 29, 2013

AdamPuzio commented Dec 12, 2013

ictliujie commented Dec 13, 2013

mostly-magic commented Dec 13, 2013

izidorome commented Jan 22, 2014

caspervonb commented Feb 5, 2014

ilanbiala commented Apr 16, 2014

sjlu commented May 27, 2014

hburrows commented May 29, 2014

richgong commented Jun 5, 2014

ilanbiala commented Jun 5, 2014

richgong commented Jun 13, 2014

flipflopsimsommer commented Jun 20, 2014

Vadorequest commented Jul 19, 2014

mde commented Jul 19, 2014

Vadorequest commented Jul 19, 2014

mebibou commented Sep 20, 2014

JeffSpies commented Sep 28, 2014

ilanbiala commented Sep 28, 2014

Vadorequest commented Sep 28, 2014

calidion commented Dec 21, 2015

huxia commented Apr 17, 2017

rossrossp commented Jul 3, 2017

MohitKumar1991 commented Jul 7, 2017

mde commented Jul 7, 2017



		//the extend symbol must be in the first place of the file if exist
		if(str.trim().indexOf(open + "+") == "0"){

Add support of extend and block in EJS #142

Add support of extend and block in EJS #142

Conversation

ictliujie commented Oct 14, 2013

izidorome commented Nov 22, 2013

welkang commented Nov 23, 2013

welkang commented Nov 23, 2013

ictliujie commented Nov 25, 2013

onurozkan commented Nov 26, 2013

tj Nov 26, 2013

Choose a reason for hiding this comment

ictliujie Nov 28, 2013

Choose a reason for hiding this comment

tj Nov 28, 2013

Choose a reason for hiding this comment

ictliujie Nov 29, 2013

Choose a reason for hiding this comment

AdamPuzio commented Dec 12, 2013

ictliujie commented Dec 13, 2013

mostly-magic commented Dec 13, 2013

izidorome commented Jan 22, 2014

caspervonb commented Feb 5, 2014

ilanbiala commented Apr 16, 2014

sjlu commented May 27, 2014

hburrows commented May 29, 2014

richgong commented Jun 5, 2014

ilanbiala commented Jun 5, 2014

richgong commented Jun 13, 2014

flipflopsimsommer commented Jun 20, 2014

Vadorequest commented Jul 19, 2014

mde commented Jul 19, 2014

Vadorequest commented Jul 19, 2014

mebibou commented Sep 20, 2014

JeffSpies commented Sep 28, 2014

ilanbiala commented Sep 28, 2014

Vadorequest commented Sep 28, 2014

calidion commented Dec 21, 2015

huxia commented Apr 17, 2017

rossrossp commented Jul 3, 2017

MohitKumar1991 commented Jul 7, 2017

mde commented Jul 7, 2017