This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix the import of vfsgen #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now vfsgen is imported in a file with `+build ignore`. This cause `go mod tidy` to delete it from go.mod and therefore breaks dependabot. This patch simply adds the import to a built file.
|
an alternative is to switch to go:embed. But that means we would require go 1.16. Thoughts? |
paulfantom
approved these changes
Oct 20, 2021
|
Referencing shurcooL/vfsgen#83 just to have a GitHub link and revert this PR when upstream issue is solved. |
|
If we include in file whose package is being used actively in Promscale, won't that include in the promscale binary and increase the size, even though its not utilized? |
|
@Harkishen-Singh I don't believe the size difference is big enough to worry about |
|
Yeah, i check and the size diff is negligible, so we can go ahead. -rwxrwxr-x 1 harkishen harkishen 31M Oct 21 12:47 promscale_master
-rwxrwxr-x 1 harkishen harkishen 31M Oct 21 12:47 promscale_pr_822 |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now vfsgen is imported in a file with
+build ignore.This cause
go mod tidyto delete it from go.mod and thereforebreaks dependabot.
This patch simply adds the import to a built file.