Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 10144 #1841

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Feb 19, 2025

Description

PR for launcher: tier4/autoware_launch#762

In this PR, I'd like to incorporate following PR to pass the parameters for traffic_light_multi_camera_fusion from autoware_launch.

Following PRs are necessary to avoid conflicts.

Related links

Parent Issue:

  • Link

How was this PR tested?

Please see autowarefoundation#10144

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

vish0012 and others added 3 commits February 19, 2025 10:20
…e and updated ReadME file for parameters setting (autowarefoundation#9994)

* feat(autoware_traffic_light_multi_camera_fusion): Created Schema file and updated ReadME file for parameters setting

Signed-off-by: vish0012 <[email protected]>

* style(pre-commit): autofix

* fix: updated param file , schema and node.cpp file  for traffic_light_multi_camera_fusion as per review comments

Signed-off-by: vish0012 <[email protected]>

* style(pre-commit): autofix

* Update traffic_light_multi_camera_fusion_node.cpp

updated code as per suggestion

* style(pre-commit): autofix

---------

Signed-off-by: vish0012 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ile (autowarefoundation#10144)

* chore(traffic_light_multi_camera_fusion): read parameters from yaml file

Signed-off-by: Tomohito Ando <[email protected]>

* style(pre-commit): autofix

* add all_traffic_light_camera param to launch.xml

Signed-off-by: Tomohito Ando <[email protected]>

* fix json schema

Signed-off-by: Tomohito Ando <[email protected]>

* remove camera namespace parameter from config file

Signed-off-by: Tomohito Ando <[email protected]>

* revert unnecessary change

Signed-off-by: Tomohito Ando <[email protected]>

* remove camera_namespaces from required

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@TomohitoAndo TomohitoAndo changed the title chore(autoware_traffic_light_multi_camera_fusion): created Schema fil… chore: cherry-pick 10144 Feb 19, 2025
@TomohitoAndo TomohitoAndo merged commit ba5e6c9 into beta/v0.41 Feb 19, 2025
36 of 39 checks passed
@TomohitoAndo TomohitoAndo deleted the chore/cherry-pick-traffic-light-multi-camera-fusion-param branch February 19, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants