feat(intrinsic_camera_calibrator): eval mode and specific camera profiles #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy calibration tools from private repository
merge main for galactic release
…g elements for eval mode
…and calibration parameters into a file, change ui elements in eval mode.
…luation_mode Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…rinsics_evaluation_mode Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…e' into feat/camera_profiles
knzo25
reviewed
Dec 23, 2024
.../intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
.../intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
.../intrinsic_camera_calibrator/intrinsic_camera_calibrator/board_detections/board_detection.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
..._camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
..._camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
..._camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
..._camera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/data_collector.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
...amera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
...amera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py
Outdated
Show resolved
Hide resolved
knzo25
reviewed
Dec 23, 2024
...amera_calibrator/intrinsic_camera_calibrator/intrinsic_camera_calibrator/views/image_view.py
Outdated
Show resolved
Hide resolved
knzo25
requested changes
Dec 23, 2024
…rator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/board_detections/board_detection.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/data_collector.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion of changing the grammar Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/views/image_view.py accepting the suggestion Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
…rator/intrinsic_camera_calibrator/data_collector.py accepting suggestion Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
|
@SergioReyesSan |
knzo25
requested changes
Dec 26, 2024
|
@SergioReyesSan |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains:
-The result of merging Ceres method with evaluation mode.
-Added a selector for a predefined configuration from a yaml file when calibrating cameras.
-Fix for set parameters: The Chessbboard detection file lacked of a set_parameter function and was not possible to set parameters from a file.
-Fixed the implementation of Aspect ratio with the new camera model selector.
Related links
Tests performed
-Performed test with rosbag and topic mode (playing a rosbag in the terminal and subscribing to the node).
-Tested the C2 and Ceres configuration with rosbag and topic mode.
Notes for reviewers
Parameters on the YAML have not been selected as the best, but are providing somehow stable results.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.