Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update to 18.1.0 #230

Merged
merged 5 commits into from
Nov 26, 2022
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 25, 2021

Fixes #229

Update dependencies to 18.1.0 and play-services-location:20.0.0

ti.playservices-android-18.1.0.zip

@build
Copy link

build commented Dec 25, 2021

Fails
🚫 version bump was Major in android/manifest but None in package.json
Messages
📖

✅ All tests are passing
Nice one! All 12 tests are passing.

📖

💾 Here are the artifacts produced:

Generated by 🚫 dangerJS against ddc89cc

@m1ga m1ga changed the title feat(android): update to 18.0.1 feat(android): update to 18.1.0 Aug 20, 2022
@m1ga
Copy link
Contributor Author

m1ga commented Aug 20, 2022

@hansemannn
Copy link
Contributor

hansemannn commented Oct 7, 2022

@m1ga Can you validate the latest version once again? Then happy to go! I think the build should also run again now.

@jordanbisato
Copy link

Since this PR, a new version of play-services-location was released, with some interesting changes:

https://developers.google.com/android/guides/releases#june_07_2022

Would be good if you can take a look.

@m1ga
Copy link
Contributor Author

m1ga commented Oct 10, 2022

Thanks for the info! I've updated the version but will need to test it again.

base is still the same version (https://mvnrepository.com/artifact/com.google.android.gms/play-services-base)

Edit: https://github.com/tidev/titanium_mobile/blob/fa604fac971579225c156a51f749011a416b2c74/android/titanium/build.gradle#L272 is another place to update the version
Edit 2: made a PR to update that too 👍

@hansemannn hansemannn merged commit f3c647a into tidev:master Nov 26, 2022
@m1ga m1ga deleted the update_18_0_1 branch November 27, 2022 09:06
@m1ga
Copy link
Contributor Author

m1ga commented Nov 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update library
4 participants