Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update to 19.0.0 #678

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

chore(android): update to 19.0.0 #678

wants to merge 16 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 21, 2024

Note: Karma tests fail because it can't find the ti.socketio module. Removing it for now so workflow is green


Update to the latest map library and map-utils.

It works but it will show logs like

[WARN]  MobStoreFlagStore: Unable to update local snapshot for com.google.android.gms.maps#com.google.android.gms, may result in stale flags.
[WARN]  MobStoreFlagStore: java.util.concurrent.ExecutionException: m.fdz: 17: 17: API: Phenotype.API is not available on this device. Connection failed with: ckg{statusCode=DEVELOPER_ERROR, resolution=null, message=null}

and

[ERROR] GoogleApiManager: Failed to get service from broker.
[ERROR] GoogleApiManager: java.lang.SecurityException: Unknown calling package name 'com.google.android.gms'.

logged here https://issuetracker.google.com/issues/228091313 or googlemaps-samples/android-samples#1474

It sounds its a playservice error (also updated those: tidev/ti.playservices#341) so nothing we can do there at the moment. It works fine but it might scare the developer

ti.map-android-5.7.0.zip

@phobeous
Copy link
Contributor

phobeous commented Jul 3, 2024

Any forecast about when this PR would be merged?

@m1ga m1ga changed the title chore(android): update to 18.2.0 chore(android): update to 19.0.0 Jul 3, 2024
@m1ga
Copy link
Contributor Author

m1ga commented Jul 3, 2024

I've updated it to the latest version 19.0.0: https://developers.google.com/android/guides/releases#june_25_2024
No new features included but it has some new APIs we could use in the future.

@phobeous
Copy link
Contributor

phobeous commented Jan 9, 2025

Hello again. We've been expecting this PR to closed and added to new ti.map release and then added to Ti SDK next release, but deadline for Apps to update to PlayServices-map +18.2.0 is close. We'll probably have to use your module build. But I think it's more desirable (and easy for many) to just add new ti.map module to next Ti SDK release.

@m1ga
Copy link
Contributor Author

m1ga commented Jan 9, 2025

@phobeous when is the deadline?

@phobeous
Copy link
Contributor

phobeous commented Jan 9, 2025

@phobeous when is the deadline?

We received this from Google (in Spanish, so I've translated):

What do I need to do?

No action is recommended if your application already uses Maps SDK for Android v18.2.0 and does not specify a renderer during the initialization process.

Updating to the latest renderer in the Maps SDK for Android may introduce a slight change in the performance and behavior of the maps in your application. Google does not anticipate this to cause any operational issues.

We recommend that developers of mission-critical applications test their app with the new renderer before the automatic update (which will occur in March 2024 or March 2025, depending on your prior situation), to minimize the risk of potential issues. You can do this by updating your app's dependencies to Maps SDK for Android version 18.2.0 or later, without specifying the legacy renderer (Renderer.LEGACY).

--
Formerly, in the same e-mail, they say that legacy rendered is programmed to be removed on 3rd March.

@m1ga
Copy link
Contributor Author

m1ga commented Jan 9, 2025

ah ok, ti.map already uses the new renderer for a few years (maps 5.4.0) unless you've set it to LEGACY. So there shouldn't be any issue here. But a new version should always be good 👍 I'm checking the workflows at the moment so it will be green again

@phobeous
Copy link
Contributor

phobeous commented Jan 9, 2025

Ah! Ok, ok! Thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants