Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip assets folder #232

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,29 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ '12', '14' ]
node: [ '20' ]
name: Node ${{ matrix.node }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- run: npm ci
name: Install dependencies
if: steps.node-cache.outputs.cache-hit != 'true'

- run: npm test
name: Build

- run: npm pack
name: Package
if: matrix.node == '12'
if: matrix.node == '20'

- uses: actions/upload-artifact@v2
if: matrix.node == '12'
- uses: actions/upload-artifact@v4
if: matrix.node == '20'
with:
name: liveview
path: liveview-*.tgz
2 changes: 1 addition & 1 deletion .github/workflows/cla.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
name: Verify contributor

steps:
- uses: tidev/tidev-cla-action@v1
- uses: tidev/tidev-cla-action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: '20'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand Down
5 changes: 4 additions & 1 deletion lib/fserver.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@

// create static file server
const fServer = http.createServer(function (request, response) {
const uri = url.parse(request.url).pathname || '';

Check warning on line 194 in lib/fserver.js

View workflow job for this annotation

GitHub Actions / Node 20

'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead
const requestPlatform = request.headers['x-platform'] || PLATFORM;
const platformFilepath = join(RESOURCE_DIR, requestPlatform, uri);
const overridePath = join(__dirname, 'overrides', uri);
Expand Down Expand Up @@ -242,7 +242,7 @@
});
let langData = {};

/**

Check warning on line 245 in lib/fserver.js

View workflow job for this annotation

GitHub Actions / Node 20

Missing JSDoc @returns for function
* [next description]
* @param {number} i [description]
*/
Expand Down Expand Up @@ -480,7 +480,10 @@
// where the file is relative to the project directory. But we should only do
// this if the file isn't an "app wide" file i.e. app.tss, config.json
const relativePath = path.relative(PROJECT_DIR, file);
if (!relativePath.startsWith('app/themes/') && !fullRecompileFiles.includes(relativePath)) {
if (!relativePath.startsWith('app/themes/')
&& !relativePath.startsWith('app/assets/')
&& !fullRecompileFiles.includes(relativePath)
) {
config = `${config},file=${relativePath}`;
}
}
Expand Down
Loading
Loading