Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper source location for should calls without a block #92

Merged

Conversation

segiddins
Copy link
Contributor

Fixes #85

@segiddins segiddins force-pushed the segiddins/should-matcher-source-location branch from 08503c3 to bc1661b Compare January 13, 2024 08:41
@segiddins segiddins force-pushed the segiddins/should-matcher-source-location branch from bc1661b to f077e2b Compare January 13, 2024 08:51
@segiddins
Copy link
Contributor Author

cc @vsppedro, if this is acceptable, a release with this plus #89 would be a huge QoL improvement 🙇🏻

@segiddins
Copy link
Contributor Author

@vsppedro is there anything else I should add to this?

@vsppedro
Copy link
Collaborator

@segiddins Sorry for not getting back to you sooner. I wanted to finish up some work on Snowglobe first, but life got in the way, and I've been feeling low on energy lately. I'll merge this and aim to release it over the weekend. Not sure if I have all the access I need though. Apologies again for the delay.

@vsppedro
Copy link
Collaborator

Thank you for your contribution!

@vsppedro vsppedro merged commit 098f0e3 into thoughtbot:main Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working as expected with minitest reporting
2 participants