Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 3 #88

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add ruby 3 #88

wants to merge 10 commits into from

Conversation

corincerami
Copy link

No description provided.

@vsppedro
Copy link
Collaborator

Thank you for your contribution. It appears that we need to include support for Ruby 3 in snowglobe in order to resolve the CI issue. What are your thoughts, @mcmire? Would you prefer an alternative approach, or are you open to a PR addressing this?

@corincerami
Copy link
Author

corincerami commented Aug 28, 2023

@vsppedro yeah, I noticed the same with Snowglobe. Interestingly, if I just change one method on version 0.3.0 of Snowglobe

# lib/snowglobe/project_command_runner.rb

def run_rake_tasks(*tasks)
  options = tasks.last.is_a?(Hash) ? tasks.pop : {}
  args = ["bundle", "exec", "rake", *tasks, "--trace"] + [options]
  run(*args)
end

to

# lib/snowglobe/project_command_runner.rb

def run_rake_tasks(*tasks)
  options = tasks.last.is_a?(Hash) ? tasks.pop : {}
  args = ["bundle", "exec", "rake", *tasks, "--trace"]
  run(*args, **options)
end

then the shoulda-context test suite passes.

Oddly however, this code is all different on snowglobe/master, which I think is Ruby 3 compatible but then raises another error that it can't find a run_n_unit_test_suite method.

@mcmire
Copy link
Collaborator

mcmire commented Nov 14, 2023

@vsppedro I realized I never responded here, sorry about that. I'm fine with bumping snowglobe to Ruby 3. I can give you access if need be.

@mcmire
Copy link
Collaborator

mcmire commented Nov 15, 2023

Oh I see, there are some breaking (and potentially buggy?) changes on the master version of Snowglobe. Hmm, okay. Well, I can still grant access, but I'll also try to look at that soon so I can unblock a fix here.

@vsppedro
Copy link
Collaborator

@mcmire, no problem. I can help you with that.

@mcmire
Copy link
Collaborator

mcmire commented Nov 16, 2023

@vsppedro Cool, just sent you an invite to the repo.

@martinemde
Copy link

martinemde commented Jul 14, 2024

Any update here? Shoulda tests are nearly 4 years behind ruby and I'm starting to find it difficult to run them locally at all.

EDIT: Upon a closer look, this PR was seemingly spawned for exactly the same reason that I opened #102. Feel free to close my PR if this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants