-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby 3 #88
base: main
Are you sure you want to change the base?
Add ruby 3 #88
Conversation
@vsppedro yeah, I noticed the same with Snowglobe. Interestingly, if I just change one method on version 0.3.0 of Snowglobe # lib/snowglobe/project_command_runner.rb
def run_rake_tasks(*tasks)
options = tasks.last.is_a?(Hash) ? tasks.pop : {}
args = ["bundle", "exec", "rake", *tasks, "--trace"] + [options]
run(*args)
end to # lib/snowglobe/project_command_runner.rb
def run_rake_tasks(*tasks)
options = tasks.last.is_a?(Hash) ? tasks.pop : {}
args = ["bundle", "exec", "rake", *tasks, "--trace"]
run(*args, **options)
end then the Oddly however, this code is all different on |
@vsppedro I realized I never responded here, sorry about that. I'm fine with bumping snowglobe to Ruby 3. I can give you access if need be. |
Oh I see, there are some breaking (and potentially buggy?) changes on the |
@mcmire, no problem. I can help you with that. |
@vsppedro Cool, just sent you an invite to the repo. |
Any update here? Shoulda tests are nearly 4 years behind ruby and I'm starting to find it difficult to run them locally at all. EDIT: Upon a closer look, this PR was seemingly spawned for exactly the same reason that I opened #102. Feel free to close my PR if this can be merged. |
No description provided.