✨ Support eval_gemfile #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| end | ||
|
|
||
| def build_gemspec(path = ".") | ||
| Dir.mkdir("tmp/stage/#{path}") rescue nil |
There was a problem hiding this comment.
Style/RescueModifier: Avoid using rescue in its modifier form.
There was a problem hiding this comment.
This was an existing pattern in the tests I merely copied.
| end | ||
|
|
||
| def build_modular_gemfile | ||
| Dir.mkdir("tmp/stage/gemfiles") rescue nil |
There was a problem hiding this comment.
Style/RescueModifier: Avoid using rescue in its modifier form.
There was a problem hiding this comment.
This was an existing pattern in the tests I merely copied.
|
I think the test suite was already broken before I made any changes @nickcharlton The new test I wrote for |
pboling
force-pushed
the
eval_gemfile
branch
2 times, most recently
from
df372a1 to
9f19d18
Compare
pboling
added a commit
to VitalConnectInc/turbo_tests
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval_gemfile#154