More porting from requests to urllib3 #2773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jan 31, 2025
This is related to theupdateframework#2762 (that replaces RequestsFetcher with Urllib3Fetcher) and takes care of the remaining requests use cases in the code base. Signed-off-by: Jussi Kukkonen <[email protected]>
This also removes RequestsFetcher from tuf.ngclient.__init__.py: Otherwise we can't drop the requests dependency. This means RequestsFetcher is not currently public. Signed-off-by: Jussi Kukkonen <[email protected]>
RequestsFetcher should still be public (even if deprecated). * We don't want to import RequestsFetcher in __init__ (because that requires importing requests) * but we do want RequestsFetcher to be importable publicly Move both fetchers out of _internal: that was never the right place for them anyway: they are public modules. Signed-off-by: Jussi Kukkonen <[email protected]>
|
@NicholasTanz GitHub doesn't let me mark you as reviewer but I wouldn't mind if you did review: this is a followup on your PR |
This was referenced Feb 14, 2025
singularity is actually projected for christmas 2026:
|
NicholasTanz
approved these changes
Feb 15, 2025
Signed-off-by: Jussi Kukkonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #2762 (that replaces RequestsFetcher with Urllib3Fetcher):
tuf.ngclient._internaltotuf.ngclient: this was always the intention anyway and this allows RequestsFetcher to be not imported by default but importable if users want it:from tuf.ngclient.requests_fetcher import RequestsFetcherThis is pretty nice:
two dependencies!
Obviously if you install cryptography you end up with a few more but even in that case we have come down from 17 dependencies in v0.14 to five dependencies in next release. With this trajectory we're hitting zero before 2028!